[IMP] sale: remove duplicate codes for price_total

The price_total field (computed) on the account.move.line model in the account module is overrid
in the sale module with a new compute method doing exactly the same thing. This override is
useless and leads to a duplicate field on the database making the ORM slower and providing
unecessary work for the migration team.

- Added on account at revision:
    https://github.com/odoo/odoo/commit/d2e33ba57c0517b88f3cdf987f6b161883b8272e#diff-f3712147f4b25231caa371bd83265dbeR1415
- Added on sale at revision:
    https://github.com/odoo/odoo/commit/3d3a23c9196b84e2189c89c107fbdf09024cca48#diff-eb374e5f26e99054eaf8b40daaebf6f9R118
This commit is contained in:
Laurent Smet
2018-02-28 16:49:21 +01:00
parent 971ed88798
commit f4262e1a36
-10
View File
@@ -96,15 +96,6 @@ class AccountInvoiceLine(models.Model):
_inherit = 'account.invoice.line'
_order = 'invoice_id, layout_category_id, sequence, id'
@api.depends('price_unit', 'discount', 'invoice_line_tax_ids', 'quantity',
'product_id', 'invoice_id.partner_id', 'invoice_id.currency_id', 'invoice_id.company_id',
'invoice_id.date_invoice')
def _compute_total_price(self):
for line in self:
price = line.price_unit * (1 - (line.discount or 0.0) / 100.0)
taxes = line.invoice_line_tax_ids.compute_all(price, line.invoice_id.currency_id, line.quantity, product=line.product_id, partner=line.invoice_id.partner_id)
line.price_total = taxes['total_included']
sale_line_ids = fields.Many2many(
'sale.order.line',
'sale_order_line_invoice_rel',
@@ -113,4 +104,3 @@ class AccountInvoiceLine(models.Model):
layout_category_id = fields.Many2one('sale.layout_category', string='Section')
layout_category_sequence = fields.Integer(string='Layout Sequence')
# TODO: remove layout_category_sequence in master or make it work properly
price_total = fields.Monetary(compute='_compute_total_price', string='Total Amount', store=True)