[FIX] web: limit amount of rows for excel export

Before this commit, when the amount of rows was above xls format threshold (>65535), the xlwt library threw an obscure Traceback to the user.

We now test the amount of rows before even calling the library, raising a more helpful message to the user

OPW 767319

closes #19035
This commit is contained in:
Lucas Perais (lpe)
2017-08-28 14:22:47 +02:00
parent 15cb84e0f7
commit f32a79dd82
+4 -1
View File
@@ -35,7 +35,7 @@ from openerp.tools import ustr
from openerp.tools.misc import str2bool, xlwt
from openerp import http
from openerp.http import request, serialize_exception as _serialize_exception, content_disposition
from openerp.exceptions import AccessError
from openerp.exceptions import AccessError, UserError
_logger = logging.getLogger(__name__)
@@ -1419,6 +1419,9 @@ class ExcelExport(ExportFormat, http.Controller):
return base + '.xls'
def from_data(self, fields, rows):
if len(rows) > 65535:
raise UserError(_('There are too many rows (%s rows, limit: 65535) to export as Excel 97-2003 (.xls) format. Consider splitting the export.') % len(rows))
workbook = xlwt.Workbook()
worksheet = workbook.add_sheet('Sheet 1')