pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] mail: runbot error accessing messaging on undefined

Browse Source 
This PR fixes the 4427 runbot error.

closes odoo/odoo#96966

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
This commit is contained in:
tsm-odoo
2022-07-28 15:03:54 +02:00
parent 171d9cffc7
commit ecd4cba040
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/mail/static/src/models/composer_view.js
+10 -6
View File
@@ -592,12 +592,16 @@ registerModel({
const chatter = this.chatter;
const { thread: chatterThread } = this.chatter || {};
const { thread: threadViewThread } = threadView;
// Keep a reference to messaging: composer could be
// unmounted while awaiting the prc promise. In this
// case, this would be undefined.
const messaging = this.messaging;
const messageData = await this.messaging.rpc({ route: `/mail/message/post`, params });
if (!this.messaging) {
if (!messaging.exists()) {
return;
}
const message = this.messaging.models['Message'].insert(
this.messaging.models['Message'].convertData(messageData)
const message = messaging.models['Message'].insert(
messaging.models['Message'].convertData(messageData)
);
for (const threadView of message.originThread.threadViews) {
// Reset auto scroll to be able to see the newly posted message.
@@ -617,9 +621,9 @@ registerModel({
}
}
if (threadViewThread) {
if (threadViewThread === this.messaging.inbox) {
this.messaging.notify({
message: sprintf(this.env._t(`Message posted on "%s"`), message.originThread.displayName),
if (threadViewThread === messaging.inbox) {
messaging.notify({
message: sprintf(messaging.env._t(`Message posted on "%s"`), message.originThread.displayName),
type: 'info',
});
if (this.exists()) {