[FIX] project: changes icon of Changes Requested state option

Before this commit, when the user is colorblind and sees the kanban
view of project.task, he cannot see the difference between
`Changes Requested` and `Approved` options and so he has to
alternatively open the form view to make sure that they are reading
it right because no check mark appeared in the dropdown to know
the current option selected.

This commit changes the icon of `Changes Requested` state option and
also adds the check mark in the dropdown options of the state field
to show which option is the current one.

task-3287326

closes odoo/odoo#121427

X-original-commit: 5e477356d2498cb0692f869053531082b4e7618f
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

addons/project/static/src/components/project_task_state_selection/project_task_state_selection.js

@@ -19,7 +19,7 @@ export class ProjectTaskStateSelection extends StateSelectionField {
         this.icons = {
             "01_in_progress": "o_status",
             "03_approved": "o_status o_status_green",
-            "02_changes_requested": "o_status o_status_bubble o_color_bubble_22",
+            "02_changes_requested": "fa fa-lg fa-exclamation-circle",
             "1_done": "fa fa-lg fa-check-circle",
             "1_canceled": "fa fa-lg fa-times-circle",
             "04_waiting_normal": "fa fa-lg fa-hourglass-o",
@@ -27,7 +27,7 @@ export class ProjectTaskStateSelection extends StateSelectionField {
         this.colorIcons = {
             "01_in_progress": "",
             "03_approved": "text-success",
-            "02_changes_requested": "text-warning",
+            "02_changes_requested": "o_status_changes_requested",
             "1_done": "text-success",
             "1_canceled": "text-danger",
             "04_waiting_normal": "",

addons/project/static/src/components/project_task_state_selection/project_task_state_selection.scss

@@ -13,10 +13,6 @@
         max-height: 20px;
     }
 
-    .o_color_bubble_22 {
-        background-color: #ffac00;
-    }
-
     .fa-hourglass-o {
         font-size: 1.4em !important;
         margin-top: 0.5px !important;
@@ -52,5 +48,9 @@
             height: 14.65px;
             text-align: center;
         }
-    }   
+    }
+
+    .o_status_changes_requested {
+        color: $warning;
+    }
 }

addons/project/static/src/components/project_task_state_selection/project_task_state_selection.xml

@@ -81,9 +81,6 @@
             <div t-if="option[0] == '1_canceled' and (currentValue != '04_waiting_normal' or this.env.isSmall)" role="separator" class="dropdown-divider"/>
         </xpath>
         <!-- Approval mode dropdown button (class)-->
-        <xpath expr="//DropdownItem" position="attributes">
-            <attribute name="class" separator=" " add="+ `dropdown-item_active_noarrow`" remove="" value=""></attribute>
-        </xpath>
         <xpath expr="//DropdownItem/span[1]" position="attributes">
             <attribute name="t-attf-class" separator=" " add="{{ stateIcon(option[0]) }}" remove="o_status"></attribute>
         </xpath>