pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] account: crazy To Check checkbox in reconciliation widget

Browse Source 
Reproduce:
Add multiple lines in the reconciliation widget
Try to create a new one and edit it

Problem:
A constraint checks that all the lines have the same value for To Check, but the value is not provided if another field changed. Since true !== undefined !== false, a warning was raised.

Solution:
Only fire check the constraint if to_check is in the values.

closes odoo/odoo#33560

Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
This commit is contained in:
wan
2019-05-22 09:22:43 +00:00
parent 54a58aa4fa
commit e9430ac5c1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/account/static/src/js/reconciliation/reconciliation_model.js
+2 -2
View File
@@ -624,12 +624,12 @@ var StatementModel = BasicModel.extend({
prop = this._formatQuickCreate(line);
line.reconciliation_proposition.push(prop);
}
if (!line.reconciliation_proposition.slice(0,-1).every(function(prop) {return prop.to_check == values.to_check})) {
if ('to_check' in values && !line.reconciliation_proposition.slice(0,-1).every(function(prop) {return prop.to_check == values.to_check})) {
new CrashManager().show_warning({data: {
exception_type: _t("Incorrect Operation"),
message: _t("You cannot mix items with and without the 'To Check' checkbox ticked.")
}});
$('.create_to_check input').click();
$('.create_to_check input:visible').prop('checked', !values.to_check).change();
return $.when();
}
_.each(values, function (value, fieldName) {