pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] web_editor: split text node on insert after delete range

Browse Source 
The `insert` command was splitting the selection's starting text node
only if the selection was collapsed. But after deleting the range, the
selection is inevitably collapsed and therefore the same should be done.

closes odoo/odoo#138549

X-original-commit: 06a375db7e6250b388d410010a3d1c50e8af1326
Signed-off-by: Antoine Guenet (age) <age@odoo.com>
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
This commit is contained in:
Antoine Guenet
2023-10-13 07:33:55 +00:00
parent 8438972939
commit e70a4baf40
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/web_editor/static/src/js/editor/odoo-editor/src/commands/commands.js
+7 -8
View File
@@ -150,18 +150,17 @@ export const editorCommands = {
insert: (editor, content) => {
if (!content) return;
const selection = editor.document.getSelection();
const range = selection.getRangeAt(0);
let startNode;
let insertBefore = false;
if (selection.isCollapsed) {
if (range.startContainer.nodeType === Node.TEXT_NODE) {
insertBefore = !range.startOffset;
splitTextNode(range.startContainer, range.startOffset, DIRECTIONS.LEFT);
startNode = range.startContainer;
}
} else {
if (!selection.isCollapsed) {
editor.deleteRange(selection);
}
const range = selection.getRangeAt(0);
if (range.startContainer.nodeType === Node.TEXT_NODE) {
insertBefore = !range.startOffset;
splitTextNode(range.startContainer, range.startOffset, DIRECTIONS.LEFT);
startNode = range.startContainer;
}
const container = document.createElement('fake-element');
const containerFirstChild = document.createElement('fake-element-fc');