pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] survey: prevent skipping filter features

Browse Source 
This commit: https://github.com/odoo/odoo/commit/0eba50dd1c33a08f8862a5718149e61b822e1b5a
introduced a 'return' in the survey.js script: return load_chart(chartConfig, '#scoring_results_chart');
This makes the rest of the script completely skipped and bypasses all the filter features.

task-2116078

closes odoo/odoo#39898

X-original-commit: b7baaf4846ba9208aeba8ba4db7de4f142e147cc
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
This commit is contained in:
mcm-odoo
2019-11-06 15:50:57 +00:00
committed by fw-bot
parent 48a9db604f
commit e6eaa062c8
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/survey/static/src/js/survey_result.js
+4 -4
View File
@@ -207,15 +207,15 @@ if(!$('.js_surveyresult').length) {
var chartConfig;
if(graph_type == 'multi_bar'){
chartConfig = init_multibar_chart(graph_data);
return load_chart(chartConfig, containerSelector);
load_chart(chartConfig, containerSelector);
}
else if(graph_type == 'bar'){
chartConfig = init_bar_chart(graph_data);
return load_chart(chartConfig, containerSelector);
load_chart(chartConfig, containerSelector);
}
else if(graph_type == 'pie'){
chartConfig = init_pie_chart(graph_data);
return load_chart(chartConfig, containerSelector);
load_chart(chartConfig, containerSelector);
}
else if (graph_type === 'doughnut') {
var quizz_score = $(graph).attr("quizz-score") || 0.0;
@@ -227,7 +227,7 @@ if(!$('.js_surveyresult').length) {
var $scoringResultsChart = $('#scoring_results_chart');
if ($scoringResultsChart.length > 0) {
var chartConfig = init_pie_chart($scoringResultsChart.data('graph_data'));
return load_chart(chartConfig, '#scoring_results_chart');
load_chart(chartConfig, '#scoring_results_chart');
}
// Script for filter