pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] website: prevent infinite loop in header animation code

Browse Source 
Bug introduced by [1]. When the header starts being animated, the main
padding-top of the page is adapted automatically with JS... but that
JS was actually starting a never-ending loop. This is fixed now.

[1]: https://github.com/odoo/odoo/commit/3defe35a0e4e2097115633797df6898ac2724c66

closes odoo/odoo#51726

X-original-commit: 07ed02608b8f4e3744c5e69c2651aa3df8bdd943
Signed-off-by: bvr-odoo <bvr-odoo@users.noreply.github.com>
This commit is contained in:
qsm-odoo
2020-05-23 10:17:27 +00:00
parent 2c9029c682
commit e3b4f3ddf4
1 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/website/static/src/js/content/menu.js
+15 -4
View File
@@ -97,12 +97,23 @@ const BaseAnimatedHeader = animations.Animation.extend({
this._transitionCount += addCount;
this._transitionCount = Math.max(0, this._transitionCount);
// The normal case would be to have the transitionend event to be
// fired but we cannot rely on it, so we use a timeout as fallback.
clearTimeout(this._paddingLoopTimer);
// As long as we detected a transition start without its related
// transition end, keep updating the main padding top.
if (this._transitionCount > 0) {
window.requestAnimationFrame(() => this._updateMainPaddingTopLoop());
this._paddingLoopTimer = setTimeout(() => this._updateMainPaddingTopLoop(-1), 500);
// The normal case would be to have the transitionend event to be
// fired but we cannot rely on it, so we use a timeout as fallback.
if (addCount !== 0) {
clearTimeout(this._paddingLoopTimer);
this._paddingLoopTimer = setTimeout(() => {
this._updateMainPaddingTopLoop(-this._transitionCount);
}, 500);
}
} else {
// When we detected all transitionend events, we need to stop the
// setTimeout fallback.
clearTimeout(this._paddingLoopTimer);
}
},