pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] web: adapt Set Defaults dialog w.r.t. owl 2

Browse Source 
This dialog hadn't been correctly adapted since the move to owl2.
As a consequence, it couldn't even open itself.

closes odoo/odoo#93571

X-original-commit: 71a0142940d46c2e954310477d6b4d7e7d14c587
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
This commit is contained in:
Aaron Bohy
2022-06-14 13:45:59 +02:00
parent cc062596f4
commit e2b7e7d6f5
3 changed files with 159 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/web/static/src/core/debug/debug_menu_items.xml
+2 -4
View File
@@ -14,8 +14,7 @@
<td class="oe_form_required">
<select id="formview_default_fields" class="o_input" t-model="state.fieldToSet">
<option value=""/>
<option t-foreach="defaultFields" t-as="field"
t-att-value="field.name">
<option t-foreach="defaultFields" t-as="field" t-att-value="field.name" t-key="field.name">
<t t-esc="field.string"/> = <t t-esc="field.displayed"/>
</option>
</select>
@@ -31,8 +30,7 @@
<td>
<select id="formview_default_conditions" class="o_input" t-model="state.condition">
<option value=""/>
<option t-foreach="conditions" t-as="cond"
t-att-value="cond.name + '=' + cond.value">
<option t-foreach="conditions" t-as="cond" t-att-value="cond.name + '=' + cond.value" t-key="cond.name">
<t t-esc="cond.string"/>=<t t-esc="cond.displayed"/>
</option>
</select>
addons/web/static/src/legacy/debug_manager.js
+1 -1
View File
@@ -216,7 +216,7 @@ SetDefaultDialog.title = _lt("Set Default");
// Form view items
function setDefaults({ action, component, env }) {
export function setDefaults({ action, component, env }) {
return {
type: "item",
description: env._t("Set Defaults"),
addons/web/static/tests/core/debug/debug_manager_tests.js
+156
View File
@@ -22,11 +22,13 @@ import {
getFixture,
legacyExtraNextTick,
mount,
nextTick,
patchWithCleanup,
} from "../../helpers/utils";
import { createWebClient, doAction, getActionManagerServerData } from "../../webclient/helpers";
import { openViewItem } from "@web/webclient/debug_items";
import { editSearchView, editView } from "@web/views/debug_items";
import { setDefaults } from "@web/legacy/debug_manager";
const { Component, xml } = owl;
@@ -504,4 +506,158 @@ QUnit.module("DebugMenu", (hooks) => {
assert.containsNone(target, ".o_debug_manager .dropdown-item");
}
);
QUnit.test("set defaults: basic rendering", async (assert) => {
prepareRegistriesWithCleanup();
patchWithCleanup(odoo, {
debug: true,
});
registry.category("services").add("user", makeFakeUserService());
registry.category("debug").category("form").add("setDefaults", setDefaults);
const serverData = getActionManagerServerData();
serverData.actions[1234] = {
id: 1234,
xml_id: "action_1234",
name: "Partners",
res_model: "partner",
res_id: 1,
type: "ir.actions.act_window",
views: [[18, "form"]],
};
serverData.views["partner,18,form"] = `
<form>
<field name="m2o"/>
<field name="foo"/>
<field name="o2m"/>
</form>`;
serverData.models["ir.ui.view"] = {
fields: {},
records: [{ id: 18 }],
};
serverData.models.partner.fields.m2o.depends = [];
serverData.models.partner.fields.foo.depends = [];
serverData.models.partner.fields.o2m.depends = [];
serverData.models.partner.records = [{ id: 1, display_name: "p1", foo: "hello" }];
const mockRPC = async (route, args) => {
if (args.method === "check_access_rights") {
return Promise.resolve(true);
}
};
const webClient = await createWebClient({ serverData, mockRPC });
await doAction(webClient, 1234);
await click(target.querySelector(".o_debug_manager button"));
await click(target.querySelector(".o_debug_manager .dropdown-item"));
assert.containsOnce(target, ".modal");
assert.containsOnce(target, ".modal select#formview_default_fields");
assert.containsN(target.querySelector(".modal #formview_default_fields"), "option", 2);
const options = target.querySelectorAll(".modal #formview_default_fields option");
assert.strictEqual(options[0].value, "");
assert.strictEqual(options[1].value, "foo");
});
QUnit.test("set defaults: click close", async (assert) => {
prepareRegistriesWithCleanup();
patchWithCleanup(odoo, {
debug: true,
});
registry.category("services").add("user", makeFakeUserService());
registry.category("debug").category("form").add("setDefaults", setDefaults);
const serverData = getActionManagerServerData();
serverData.actions[1234] = {
id: 1234,
xml_id: "action_1234",
name: "Partners",
res_model: "partner",
res_id: 1,
type: "ir.actions.act_window",
views: [[18, "form"]],
};
serverData.views["partner,18,form"] = `
<form>
<field name="foo"/>
</form>`;
serverData.models["ir.ui.view"] = {
fields: {},
records: [{ id: 18 }],
};
serverData.models.partner.fields.foo.depends = [];
serverData.models.partner.records = [{ id: 1, display_name: "p1", foo: "hello" }];
const mockRPC = async (route, args) => {
if (args.method === "set" && args.model === "ir.default") {
throw new Error("should not create a default");
}
if (args.method === "check_access_rights") {
return Promise.resolve(true);
}
};
const webClient = await createWebClient({ serverData, mockRPC });
await doAction(webClient, 1234);
await click(target.querySelector(".o_debug_manager button"));
await click(target.querySelector(".o_debug_manager .dropdown-item"));
assert.containsOnce(target, ".modal");
await click(target.querySelector(".modal .modal-footer button"));
assert.containsNone(target, ".modal");
});
QUnit.test("set defaults: select and save", async (assert) => {
assert.expect(3);
prepareRegistriesWithCleanup();
patchWithCleanup(odoo, {
debug: true,
});
registry.category("services").add("user", makeFakeUserService());
registry.category("debug").category("form").add("setDefaults", setDefaults);
const serverData = getActionManagerServerData();
serverData.actions[1234] = {
id: 1234,
xml_id: "action_1234",
name: "Partners",
res_model: "partner",
res_id: 1,
type: "ir.actions.act_window",
views: [[18, "form"]],
};
serverData.views["partner,18,form"] = `
<form>
<field name="foo"/>
</form>`;
serverData.models["ir.ui.view"] = {
fields: {},
records: [{ id: 18 }],
};
serverData.models.partner.fields.foo.depends = [];
serverData.models.partner.records = [{ id: 1, display_name: "p1", foo: "hello" }];
const mockRPC = async (route, args) => {
if (args.method === "check_access_rights") {
return Promise.resolve(true);
}
if (args.method === "set" && args.model === "ir.default") {
assert.deepEqual(args.args, ["partner", "foo", "hello", true, true, false]);
return true;
}
};
const webClient = await createWebClient({ serverData, mockRPC });
await doAction(webClient, 1234);
await click(target.querySelector(".o_debug_manager button"));
await click(target.querySelector(".o_debug_manager .dropdown-item"));
assert.containsOnce(target, ".modal");
const select = target.querySelector(".modal #formview_default_fields");
select.value = "foo";
select.dispatchEvent(new Event("change"));
await nextTick();
await click(target.querySelectorAll(".modal .modal-footer button")[1]);
assert.containsNone(target, ".modal");
});
});