pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] web: SettingsPage propagate NoContentHelper slot

Browse Source 
Before this commit, we propagate all the slots to the SettingsPage. This
could raise an issue if the default slot (propagated) has a content, for
more information see: https://github.com/odoo/owl/issues/1256

Now, to avoid this, we only propagate the slots that are used on the
SettingsPage component, ie: NoContentHelper.

closes odoo/odoo#100362

Signed-off-by: Géry Debongnie <ged@odoo.com>
Co-authored-by: Lucas Perais <lpe@odoo.com>
This commit is contained in:
Jorge Pinna Puissant
2022-09-16 16:20:49 +02:00
co-authored by Lucas Perais
parent 0ae8a6b03a
commit e234810faa
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/web/static/src/webclient/settings_form_view/settings_form_compiler.js
+1 -1
View File
@@ -6,7 +6,7 @@ import { getModifier } from "@web/views/view_compiler";
function compileSettingsPage(el, params) {
const settingsPage = createElement("SettingsPage");
settingsPage.setAttribute("slots", "props.slots");
settingsPage.setAttribute("slots", "{NoContentHelper:props.slots.NoContentHelper}");
settingsPage.setAttribute("initialTab", "props.initialApp");
settingsPage.setAttribute("t-slot-scope", "settings");
addons/web/static/tests/webclient/settings_form_view/settings_form_view_tests.js
+1 -1
View File
@@ -1424,7 +1424,7 @@ QUnit.module("SettingsFormView", (hooks) => {
const expectedCompiled = `
<div class="o_setting_container">
<SettingsPage slots="props.slots" initialTab="props.initialApp" t-slot-scope="settings" modules="[{&quot;key&quot;:&quot;crm&quot;,&quot;string&quot;:&quot;CRM&quot;,&quot;imgurl&quot;:&quot;/crm/static/description/icon.png&quot;,&quot;isVisible&quot;:false}]" class="'settings'">
<SettingsPage slots="{NoContentHelper:props.slots.NoContentHelper}" initialTab="props.initialApp" t-slot-scope="settings" modules="[{&quot;key&quot;:&quot;crm&quot;,&quot;string&quot;:&quot;CRM&quot;,&quot;imgurl&quot;:&quot;/crm/static/description/icon.png&quot;,&quot;isVisible&quot;:false}]" class="'settings'">
<SettingsApp t-props="{&quot;key&quot;:&quot;crm&quot;,&quot;string&quot;:&quot;CRM&quot;,&quot;imgurl&quot;:&quot;/crm/static/description/icon.png&quot;,&quot;isVisible&quot;:false}" selectedTab="settings.selectedTab" class="'app_settings_block'">
<FormLabel t-props="{id:'display_name',fieldName:'display_name',record:props.record,fieldInfo:props.archInfo.fieldNodes['display_name'],className:&quot;highhopes&quot;}" string="\`My&quot; little ' Label\`"/>
<Field id="'display_name'" name="'display_name'" record="props.record" fieldInfo="props.archInfo.fieldNodes['display_name']"/>