[IMP] put better error message when widget options are not valid JSON

bzr revid: nicolas.vanhoren@openerp.com-20121009093035-1y3fxr95qo2thryq
2012-10-09 11:30:35 +02:00
parent 2f6ad073ba
commit dfad511a55
1 changed files with 5 additions and 1 deletions
@@ -2068,7 +2068,11 @@ instance.web.form.AbstractField = instance.web.form.FormWidget.extend(instance.w
        this.field = this.field_manager.get_field_desc(this.name);
        this.widget = this.node.attrs.widget;
        this.string = this.node.attrs.string || this.field.string || this.name;
-        this.options = JSON.parse(this.node.attrs.options || '{}');
+        try {
+            this.options = JSON.parse(this.node.attrs.options || '{}');
+        } catch (e) {
+            throw new Error(_.str.sprintf(_t("Widget options for field '%s' are not valid JSON."), this.name));
+        }
        this.set({'value': false});

        this.on("change:value", this, function() {