pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] website: adapt cookies bar buttons to match security concerns

Browse Source 
The cookies bar default templates are designed in order to guide the
user towards selecting the option that will provide the best user
experience.
This raises security concerns (see discussion in PR for details).

This commit adapts the buttons of the default cookies bar templates so
that both options are shown with the same style, forcing the user to
take a decision.

task-2800976

closes odoo/odoo#101845

X-original-commit: 32d88f47a67679b7e90fa58e25089846484b48ca
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
This commit is contained in:
Benoit Socias
2022-10-03 10:56:59 +02:00
parent 878351d840
commit dc0ffd2015
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/website/static/src/xml/website.cookies_bar.xml
+4 -4
View File
@@ -17,11 +17,11 @@
</t>
<t t-name="website.cookies_bar.text_button_all">
<a href="#" id="cookies-consent-all" role="button"
class="js_close_popup o_cookies_bar_accept_all o_cookies_bar_text_button btn btn-primary mb-1 px-2 py-1">Allow all cookies</a>
class="js_close_popup o_cookies_bar_accept_all o_cookies_bar_text_button btn btn-outline-primary rounded-circle mb-1 px-2 py-1">Allow all cookies</a>
</t>
<t t-name="website.cookies_bar.text_button_essential">
<a href="#" id="cookies-consent-essential" role="button"
class="js_close_popup o_cookies_bar_accept_essential o_cookies_bar_text_button_essential btn btn-link mt-1 mb-2 px-2 py-1">Only allow essential cookies</a>
class="js_close_popup o_cookies_bar_accept_essential o_cookies_bar_text_button_essential btn btn-outline-primary rounded-circle mt-1 mb-2 px-2 py-1">Only allow essential cookies</a>
</t>
<t t-name="website.cookies_bar.discrete">
<!-- When updating this template, do not forget to also update the
@@ -35,9 +35,9 @@
</div>
<div class="col-lg-4 text-end">
<a href="#" id="cookies-consent-essential" role="button"
class="js_close_popup btn btn-link btn-sm px-2">Only essentials</a>
class="js_close_popup btn btn-outline-primary rounded-circle btn-sm px-2">Only essentials</a>
<a href="#" id="cookies-consent-all" role="button"
class="js_close_popup btn btn-primary btn-sm">I agree</a>
class="js_close_popup btn btn-outline-primary rounded-circle btn-sm">I agree</a>
</div>
</div>
</div>
addons/website/views/website_templates.xml
+2 -2
View File
@@ -1904,9 +1904,9 @@
</div>
<div class="col-lg-4 text-end">
<a href="#" id="cookies-consent-essential" role="button"
class="js_close_popup btn btn-link btn-sm px-2">Only essentials</a>
class="js_close_popup btn btn-outline-primary rounded-circle btn-sm px-2">Only essentials</a>
<a href="#" id="cookies-consent-all" role="button"
class="js_close_popup btn btn-primary btn-sm">I agree</a>
class="js_close_popup btn btn-outline-primary rounded-circle btn-sm">I agree</a>
</div>
</div>
</div>