pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] pos_restaurant: handle parse error if reinstall pos restaurant module

Browse Source 
This traceback arises when the user tries to reinstall the 'pos_restaurant'
module

ParseError:
Parse error rises

When users try to reinstall the 'pos_restaurant', a traceback will be
generated. Because duplicate 'MRCSH'records exist, they raise the ParseError.

Which leads to the traceback from here

https://github.com/odoo/odoo/blob/8b4f4f2e373896fcaa50f6ee55467274f8e440d5/addons/pos_restaurant/models/pos_config.py#L134-L139

After applying this commit, it will resolve the issue by if the
pos payment methodexists, returning the values otherwise create it.

sentry-4736057055

closes odoo/odoo#147539

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
This commit is contained in:
vevi-odoo
2024-01-10 19:39:23 +00:00
parent fe4385aca3
commit db858c7a13
1 changed files with 32 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/point_of_sale/models/pos_config.py
+32 -12
View File
@@ -720,23 +720,43 @@ class PosConfig(models.Model):
if pms:
self.payment_method_ids = [Command.link(pm.id) for pm in pms]
def _is_journal_exist(self, journal_code, name, company_id):
account_journal = self.env['account.journal']
existing_journal = account_journal.search([
('name', '=', name),
('code', '=', journal_code),
('company_id', '=', company_id),
], limit=1)
return existing_journal.id or account_journal.create({
'name': name,
'code': journal_code,
'type': 'cash',
'company_id': company_id,
}).id
def _is_pos_pm_exist(self, name, journal_id, company_id):
pos_payment = self.env['pos.payment.method']
existing_pos_cash_pm = pos_payment.search([
('name', '=', name),
('journal_id', '=', journal_id),
('company_id', '=', company_id),
], limit=1)
return existing_pos_cash_pm.id or pos_payment.create({
'name': name,
'journal_id': journal_id,
'company_id': company_id,
}).id
def _ensure_cash_payment_method(self, journal_code, name):
self.ensure_one()
if not self.company_id.chart_template or self.payment_method_ids.filtered('is_cash_count'):
return
company_id = self.company_id.id
cash_journal = self.env['account.journal'].create({
'name': name,
'code': journal_code,
'type': 'cash',
'company_id': company_id,
})
cash_pm = self.env['pos.payment.method'].create({
'name': name,
'journal_id': cash_journal.id,
'company_id': company_id,
})
self.payment_method_ids = [Command.link(cash_pm.id)]
cash_journal_id = self._is_journal_exist(journal_code, name, company_id)
cash_pm_id = self._is_pos_pm_exist(name, cash_journal_id, company_id)
self.payment_method_ids = [Command.link(cash_pm_id)]
def get_limited_products_loading(self, fields):
tables, where_clause, params = self.env['product.product']._where_calc(