pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[IMP] portal_rating: clean attributes of star element in rating composer

Browse Source 
When hovering a star, a title is disturbing since a description is already
displayed to the user. "One star" is therefore confusing since it will appear
on every star, even for the fourth one out of five, for instance. Therefore,
all titles are removed from stars. Also, to avoid this confusion in aria label,
we do not use numbers in cleaned labels.

Task-2728564

Part-of: odoo/odoo#82792
This commit is contained in:
Noe Antoine
2022-02-22 19:47:54 +00:00
committed by Thibault Delavallée
parent 4ddeca9ad0
commit db82f55330
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/portal_rating/static/src/xml/portal_tools.xml
+4 -4
View File
@@ -74,13 +74,13 @@
<div class="stars enabled">
<t t-foreach="_.range(0, val_integer)" t-as="num">
<i class="fa fa-star" role="img" aria-label="One star" title="One star"></i>
<i class="fa fa-star" role="img" aria-label="Full star"></i>
</t>
<t t-if="val_decimal">
<i class="fa fa-star-half-o" role="img" aria-label="Half a star" title="Half a star"></i>
<i class="fa fa-star-half-o" role="img" aria-label="Half a star"></i>
</t>
<t t-foreach="_.range(0, empty_star)" t-as="num" role="img" t-attf-aria-label="#{empty_star} on 5" t-attf-title="#{empty_star} on 5">
<i class="fa fa-star-o text-black-25"></i>
<t t-foreach="_.range(0, empty_star)" t-as="num">
<i class="fa fa-star-o text-black-25" role="img" aria-label="Empty star"></i>
</t>
</div>
<div class="rate_text">