pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[IMP] product: improve creation performance.

Browse Source 
The default product category and uom should be fixed on generic 
undeletable records (in data files).

And by caching those default values, we can gain up to 20% time when 
creating products without providing uom and categories.

Also remove the unnecessary defaults on the compute fields, which do the 
same as the compute (and have no use because it is a non stored field).

closes odoo/odoo#45791

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
This commit is contained in:
Victor Feyens
2020-02-20 14:51:13 +00:00
parent 5ccdc1540d
commit d3bbe14c8d
1 changed files with 8 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/product/models/product_template.py
+8 -20
View File
@@ -17,27 +17,15 @@ class ProductTemplate(models.Model):
_description = "Product Template"
_order = "name"
@tools.ormcache()
def _get_default_category_id(self):
if self._context.get('categ_id') or self._context.get('default_categ_id'):
return self._context.get('categ_id') or self._context.get('default_categ_id')
category = self.env.ref('product.product_category_all', raise_if_not_found=False)
if not category:
category = self.env['product.category'].search([], limit=1)
if category:
return category.id
else:
err_msg = _('You must define at least one product category in order to be able to create products.')
redir_msg = _('Go to Internal Categories')
raise RedirectWarning(err_msg, self.env.ref('product.product_category_action_form').id, redir_msg)
# Deletion forbidden (at least through unlink)
return self.env.ref('product.product_category_all')
@tools.ormcache()
def _get_default_uom_id(self):
return self.env["uom.uom"].search([], limit=1, order='id').id
def _get_default_weight_uom(self):
return self._get_weight_uom_name_from_ir_config_parameter()
def _get_default_volume_uom(self):
return self._get_volume_uom_name_from_ir_config_parameter()
# Deletion forbidden (at least through unlink)
return self.env.ref('uom.product_uom_unit')
def _read_group_categ_id(self, categories, domain, order):
category_ids = self.env.context.get('default_categ_id')
@@ -97,11 +85,11 @@ class ProductTemplate(models.Model):
volume = fields.Float(
'Volume', compute='_compute_volume', inverse='_set_volume', digits='Volume', store=True)
volume_uom_name = fields.Char(string='Volume unit of measure label', compute='_compute_volume_uom_name', default=_get_default_volume_uom)
volume_uom_name = fields.Char(string='Volume unit of measure label', compute='_compute_volume_uom_name')
weight = fields.Float(
'Weight', compute='_compute_weight', digits='Stock Weight',
inverse='_set_weight', store=True)
weight_uom_name = fields.Char(string='Weight unit of measure label', compute='_compute_weight_uom_name', readonly=True, default=_get_default_weight_uom)
weight_uom_name = fields.Char(string='Weight unit of measure label', compute='_compute_weight_uom_name')
sale_ok = fields.Boolean('Can be Sold', default=True)
purchase_ok = fields.Boolean('Can be Purchased', default=True)