pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] purchase_stock: improve partner._compute_on_time_rate perfs

Browse Source 
Improve res.patner._compute_on_time_rate performances by calling
mapped('quantity_done') once on all the order_lines.move_ids.

Moving it out of the for loop allows to befinit from the performance
gains of the read_group call in stock.move._quantity_done_compute.

closes odoo/odoo#72422

X-original-commit: 2841525a3a2f1273783874947884b57494def849
Signed-off-by: Rémy Voet <ryv-odoo@users.noreply.github.com>
This commit is contained in:
Aurélien (avd)
2021-06-21 11:00:02 +00:00
parent 49f95a9a00
commit ca478f03ce
2 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/purchase_stock/models/res_partner.py
+10 -2
View File
@@ -2,6 +2,7 @@
# Part of Odoo. See LICENSE file for full copyright and licensing details.
from datetime import timedelta, datetime, time
from collections import defaultdict
from odoo import api, fields, models
@@ -20,12 +21,19 @@ class ResPartner(models.Model):
('partner_id', 'in', self.ids),
('date_order', '>', fields.Date.today() - timedelta(365)),
('qty_received', '!=', 0),
]).filtered(lambda l: l.product_id.sudo().product_tmpl_id.type != 'service' and l.order_id.state in ['done', 'purchase'])
('order_id.state', 'in', ['done', 'purchase'])
]).filtered(lambda l: l.product_id.sudo().product_tmpl_id.type != 'service')
lines_qty_done = defaultdict(lambda: 0)
moves = self.env['stock.move'].search([
('purchase_line_id', 'in', order_lines.ids),
('state', '=', 'done')]).filtered(lambda m: m.date.date() <= m.purchase_line_id.date_planned.date())
for move, qty_done in zip(moves, moves.mapped('quantity_done')):
lines_qty_done[move.purchase_line_id.id] += qty_done
partner_dict = {}
for line in order_lines:
on_time, ordered = partner_dict.get(line.partner_id, (0, 0))
ordered += line.product_uom_qty
on_time += sum(line.mapped('move_ids').filtered(lambda m: m.state == 'done' and m.date.date() <= m.purchase_line_id.date_planned.date()).mapped('quantity_done'))
on_time += lines_qty_done[line.id]
partner_dict[line.partner_id] = (on_time, ordered)
seen_partner = self.env['res.partner']
for partner, numbers in partner_dict.items():
addons/stock/models/stock_move.py
+3 -3
View File
@@ -319,12 +319,12 @@ class StockMove(models.Model):
move.quantity_done = quantity_done
else:
# compute
move_lines = self.env['stock.move.line']
move_lines_ids = set()
for move in self:
move_lines |= move._get_move_lines()
move_lines_ids |= set(move._get_move_lines().ids)
data = self.env['stock.move.line'].read_group(
[('id', 'in', move_lines.ids)],
[('id', 'in', list(move_lines_ids))],
['move_id', 'product_uom_id', 'qty_done'], ['move_id', 'product_uom_id'],
lazy=False
)