[FIX] hr_holidays: reset holiday_status_id when changing employee

addons/hr_holidays/models/hr_leave_allocation.py

@@ -296,6 +296,8 @@ class HolidaysAllocation(models.Model):
     @api.onchange('employee_id')
     def _onchange_employee(self):
         self.manager_id = self.employee_id and self.employee_id.parent_id
+        if self.employee_id.user_id != self.env.user:
+            self.holiday_status_id = False
         if self.holiday_type == 'employee':
             self.department_id = self.employee_id.department_id
 
@@ -374,8 +376,6 @@ class HolidaysAllocation(models.Model):
         holiday.add_follower(employee_id)
         if holiday.validation_type == 'hr':
             holiday.message_subscribe(partner_ids=(holiday.employee_id.parent_id.user_id.partner_id | holiday.employee_id.leave_manager_id.partner_id).ids)
-        if 'employee_id' in values:
-            holiday._onchange_employee()
         if not self._context.get('import_file'):
             holiday.activity_update()
         return holiday