pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[IMP] base: make res.config.settings strict about field definitions

Browse Source 
This way we avoid wrongly configured fields and triggering a behavior
without knowing it.
This commit is contained in:
Raphael Collet
2018-01-16 13:34:29 +01:00
committed by Thibault Delavallée
parent a18bd499ac
commit c434d7f947
1 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
odoo/addons/base/models/res_config.py
+14 -11
View File
@@ -451,24 +451,27 @@ class ResConfigSettings(models.TransientModel, ResConfigModuleInstallationMixin)
defaults, groups, modules, configs, others = [], [], [], [], []
for name, field in self._fields.items():
if name.startswith('default_') and hasattr(field, 'default_model'):
if name.startswith('default_'):
if not hasattr(field, 'default_model'):
raise Exception("Field %s without attribute 'default_model'" % field)
defaults.append((name, field.default_model, name[8:]))
elif name.startswith('group_') and field.type in ('boolean', 'selection') and \
hasattr(field, 'implied_group'):
elif name.startswith('group_'):
if field.type not in ('boolean', 'selection'):
raise Exception("Field %s must have type 'boolean' or 'selection'" % field)
if not hasattr(field, 'implied_group'):
raise Exception("Field %s without attribute 'implied_group'" % field)
field_group_xmlids = getattr(field, 'group', 'base.group_user').split(',')
field_groups = Groups.concat(*(ref(it) for it in field_group_xmlids))
groups.append((name, field_groups, ref(field.implied_group)))
elif name.startswith('module_') and field.type in ('boolean', 'selection'):
elif name.startswith('module_'):
if field.type not in ('boolean', 'selection'):
raise Exception("Field %s must have type 'boolean' or 'selection'" % field)
module = IrModule.sudo().search([('name', '=', name[7:])], limit=1)
modules.append((name, module))
elif hasattr(field, 'config_parameter'):
if field.type in ('boolean', 'char', 'selection', 'many2one', 'integer', 'float'):
configs.append((name, field.config_parameter))
else:
msg = "Error with field %s !" \
"Automatic ir.config_parameter getting/setting is not implemented for %s's." \
% (name, field.type)
raise Exception(msg)
if field.type not in ('boolean', 'integer', 'float', 'char', 'selection', 'many2one'):
raise Exception("Field %s must have type 'boolean', 'integer', 'float', 'char', 'selection' or 'many2one'" % field)
configs.append((name, field.config_parameter))
else:
others.append(name)