pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] account: traceback on invoice lines update+delete

Browse Source 
Create an Invoice with 2 lines of product
Save
Delete one
Change currency
Save

Traceback will occur becasue of a ValueError
```
    for command, line_id, line_vals in vals['invoice_line_ids']
ValueError: not enough values to unpack (expected 3, got 2)
```

opw-3672799

closes odoo/odoo#149261

Signed-off-by: William André (wan) <wan@odoo.com>
This commit is contained in:
Andrea Grazioso (agr-odoo)
2024-01-12 18:55:03 +00:00
parent 70af882e54
commit c366efa675
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/account/models/account_move.py
+5 -5
View File
@@ -2393,8 +2393,8 @@ class AccountMove(models.Model):
# both fields, sometimes one field can be explicitely empty while the other
# one is not, sometimes not...
update_vals = {
line_id: line_vals
for command, line_id, line_vals in vals['invoice_line_ids']
line_id: line_vals[0]
for command, line_id, *line_vals in vals['invoice_line_ids']
if command == Command.UPDATE
}
for command, line_id, line_vals in vals['line_ids']:
@@ -2402,10 +2402,10 @@ class AccountMove(models.Model):
line_vals.update(update_vals.pop(line_id))
for line_id, line_vals in update_vals.items():
vals['line_ids'] += [Command.update(line_id, line_vals)]
for command, line_id, line_vals in vals['invoice_line_ids']:
for command, line_id, *line_vals in vals['invoice_line_ids']:
assert command not in (Command.SET, Command.CLEAR)
if [command, line_id, line_vals] not in vals['line_ids']:
vals['line_ids'] += [(command, line_id, line_vals)]
if [command, line_id, *line_vals] not in vals['line_ids']:
vals['line_ids'] += [(command, line_id, *line_vals)]
del vals['invoice_line_ids']
return vals