pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] website: fix wrong translation check due to transifex change

Browse Source 
Somehow the already translated term `Save` in french was translated
again from `Sauvegarder` to `Sauver`.

We already faced that issue when forward porting the tour as that
translation was not the same between versions, see [1].

The tour should be adapted to create a new fake language and some
translations for it (the ones being checked in the tour) to make it more
robust and not impacted by the real translation from transifex.
It would also makes the test faster as it wouldn't have to load a real
language which has a lot of translations.

As this is blocking and preventing any r+ in saas-15.3 a day before the
saas-15.4 freeze/release, this quick fix is introduced in the meantime.

[1]: https://github.com/odoo/odoo/pull/84528#issuecomment-1041323974

closes odoo/odoo#92938

X-original-commit: 594ac2c9651f27cc1623fcd5b916cb191241651b
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
This commit is contained in:
Romain Derie
2022-06-07 00:05:54 +02:00
parent 08030d3409
commit bc1389ee89
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/website/static/tests/tours/configurator_translation.js
+10 -4
View File
@@ -52,11 +52,17 @@ tour.register('configurator_translation', {
trigger: 'body.editor_started',
timeout: 30000,
}, {
// Check the content of the save button to make sure
// the website is in French. (The editor should be in the website's
// default language, which should be french in this test.)
// Check the content of the save button to make sure the website is in
// French. (The editor should be in the website's default language,
// which should be french in this test.)
// Also note that sometimes the translation is being changed on
// Transifex from "Sauvegarder" to "Sauver" or the other way around.
// TODO: Strengthen this tour by creating a new fake language and some
// translations for the checked terms. See what's done in `Sign`
// `test_translate_sign_instructions` tour with the `Parseltongue`
// language.
content: "exit edit mode",
trigger: '.o_we_website_top_actions button.btn-primary:contains("Sauvegarder")',
trigger: '.o_we_website_top_actions button.btn-primary:contains("Sauvegarder"), .o_we_website_top_actions button.btn-primary:contains("Sauver")',
}, {
content: "wait for editor to be closed",
trigger: 'body:not(.editor_enable)',