pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] payment_authorize: avoid method name ambiguity

Browse Source 
_prepare_transaction_request() introduced in
35a6c1867d8edc9b58c002a6ff6a63c35a0fc708 is only used for
'authOnlyTransaction' and 'authCaptureTransaction' transaction
types. capture(), void() and refund() still build their own request
parameters. Make this clearer by renaming _prepare_transaction_request()
to _prepare_authorization_transaction_request().

closes odoo/odoo#73373

X-original-commit: da00ae85f69cfde217d09b93113f8b7821aabff2
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
This commit is contained in:
Joren Van Onder
2021-07-07 12:22:11 +00:00
parent 38fc6a6e80
commit b934f7cb9f
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/payment_authorize/models/authorize_request.py
+3 -3
View File
@@ -138,7 +138,7 @@ class AuthorizeAPI:
return self._format_response(response, 'deleteCustomerProfile')
#=== Transaction management ===#
def _prepare_transaction_request(self, transaction_type, tx_data, amount, reference):
def _prepare_authorization_transaction_request(self, transaction_type, tx_data, amount, reference):
return {
'transactionRequest': {
'transactionType': transaction_type,
@@ -166,7 +166,7 @@ class AuthorizeAPI:
tx_data = self._prepare_tx_data(token=token, opaque_data=opaque_data)
response = self._make_request(
'createTransactionRequest',
self._prepare_transaction_request('authOnlyTransaction', tx_data, amount, reference)
self._prepare_authorization_transaction_request('authOnlyTransaction', tx_data, amount, reference)
)
return self._format_response(response, 'auth_only')
@@ -187,7 +187,7 @@ class AuthorizeAPI:
tx_data = self._prepare_tx_data(token=token, opaque_data=opaque_data)
response = self._make_request(
'createTransactionRequest',
self._prepare_transaction_request('authCaptureTransaction', tx_data, amount, reference)
self._prepare_authorization_transaction_request('authCaptureTransaction', tx_data, amount, reference)
)
result = self._format_response(response, 'auth_capture')