pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[IMP] point_of_sale: remove unused function

Browse Source 
before this commit, in point_of_sale module there is
a function _get_reconciled_vals, which is left over
in this commit: https://github.com/odoo/odoo/commit/785d49f3f0a21720d8c929d597d4041918ab7f41

initially the function is inherited to bring the payment
method name in the invoice report from the pos, but it is
decided not to add it again to keep it same from accounting
and point of sale.

Discussion: https://github.com/odoo/odoo/pull/125995#issuecomment-1643938775

after this commit, the unused function will be
removed from the code.

closes odoo/odoo#129499

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
This commit is contained in:
niyasraphy
2023-07-25 13:26:34 +02:00
parent 966f366bfc
commit b4c828622b
1 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/point_of_sale/models/account_move.py
-7
View File
@@ -44,13 +44,6 @@ class AccountMove(models.Model):
return lot_values
def _get_reconciled_vals(self, partial, amount, counterpart_line):
"""Add pos_payment_name field in the reconciled vals to be able to show the payment method in the invoice."""
result = super()._get_reconciled_vals(partial, amount, counterpart_line)
if counterpart_line.move_id.sudo().pos_payment_ids:
pos_payment = counterpart_line.move_id.sudo().pos_payment_ids
result['pos_payment_name'] = pos_payment.payment_method_id.name
return result
class AccountMoveLine(models.Model):
_inherit = 'account.move.line'