pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[IMP] web: boot.js: throw even if not in debug

Browse Source 
Before this commit, when a module wasn't correctly defined (e.g.
wrong format for dependencies, wrong format for module name, name
already defined...), an error was thrown but only in debug mode.
In non debug mode, the problem was simply ignored, which is wrong.

An example of harmful consequence would be the following: if
someone defines a new test file and uses an already used module
name, he won't be notified of his mistake unless he runs the suite
in debug mode. If he doesn't, the runbot won't detect it either as
it runs tests in non debug mode. It would then lead to one of the
two test suites not being executed.

Fun fact: a lazy loaded file was actually loaded twice, but we were
only notified in debug mode. With this change, it made the test
suite fail all the time, no matter the mode. We simply removed the
file from the page source, and let the first test needing it lazy
load it.

closes odoo/odoo#66918

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
This commit is contained in:
Aaron Bohy
2021-03-30 08:57:35 +00:00
parent 5732ce8dc6
commit aa07146421
2 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/web/static/src/js/boot.js
+11 -13
View File
@@ -123,19 +123,17 @@
});
}
if (odoo.debug) {
if (!(deps instanceof Array)) {
throw new Error('Dependencies should be defined by an array', deps);
}
if (typeof factory !== 'function') {
throw new Error('Factory should be defined by a function', factory);
}
if (typeof name !== 'string') {
throw new Error("Invalid name definition (should be a string", name);
}
if (name in factories) {
throw new Error("Service " + name + " already defined");
}
if (!(deps instanceof Array)) {
throw new Error('Dependencies should be defined by an array', deps);
}
if (typeof factory !== 'function') {
throw new Error('Factory should be defined by a function', factory);
}
if (typeof name !== 'string') {
throw new Error("Invalid name definition (should be a string", name);
}
if (name in factories) {
throw new Error("Service " + name + " already defined");
}
factory.deps = deps;
addons/web/views/webclient_templates.xml
-1
View File
@@ -640,7 +640,6 @@
<script type="text/javascript" src="/web/static/lib/nearest/jquery.nearest.js"/>
<script type="text/javascript" src="/web/static/lib/daterangepicker/daterangepicker.js"></script>
<script type="text/javascript" src="/web/static/lib/stacktracejs/stacktrace.js"></script>
<script type="text/javascript" src="/web/static/src/js/libs/daterangepicker.js"></script>
<script type="text/javascript" src="/web/static/tests/main_tests.js"></script>