pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[IMP] core: add float_utils shortcuts to fields.Float

Browse Source 
With this commit, the functions float_compare, float_round and
float_is_zero are available from the fields.Float class as static
methods.

This allows the usage of these helper methods without the need to import
them from odoo.tools.

closes odoo/odoo#39695

Signed-off-by: Adrian Torres (adt) <adt@odoo.com>
This commit is contained in:
Florent de Labarre
2019-11-08 08:16:27 +00:00
committed by Adrian Torres
parent 6fae598d2c
commit a67d6eff45
1 changed files with 40 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
odoo/fields.py
+40 -2
View File
@@ -20,12 +20,16 @@ except ImportError:
import psycopg2
from .tools import float_repr, float_round, frozendict, html_sanitize, human_size, pg_varchar, \
ustr, OrderedSet, pycompat, sql, date_utils, unique, IterableGenerator, image_process, merge_sequences
from .tools import (
float_repr, float_round, float_compare, float_is_zero, frozendict, html_sanitize, human_size,
pg_varchar, ustr, OrderedSet, pycompat, sql, date_utils, unique, IterableGenerator,
image_process, merge_sequences,
)
from .tools import DEFAULT_SERVER_DATE_FORMAT as DATE_FORMAT
from .tools import DEFAULT_SERVER_DATETIME_FORMAT as DATETIME_FORMAT
from .tools.translate import html_translate, _
from .tools.mimetypes import guess_mimetype
from odoo.exceptions import CacheMiss
DATE_LENGTH = len(date.today().strftime(DATE_FORMAT))
@@ -1146,6 +1150,36 @@ class Float(Field):
:param digits: a pair (total, decimal) or a
string referencing a `decimal.precision` record.
:type digits: tuple(int,int) or str
When a float is a quantity associated with an unit of measure, it is important
to use the right tool to compare or round values with the correct precision.
The Float class provides some static methods for this purpose:
:func:`~odoo.fields.Float.round()` to round a float with the given precision.
:func:`~odoo.fields.Float.is_zero()` to check if a float equals zero at the given precision.
:func:`~odoo.fields.Float.compare()` to compare two floats at the given precision.
.. admonition:: Example
To round a quantity with the precision of the unit of mesure::
fields.Float.round(self.product_uom_qty, precision_rounding=self.product_uom_id.rounding)
To check if the quantity is zero with the precision of the unit of mesure::
fields.Float.is_zero(self.product_uom_qty, precision_rounding=self.product_uom_id.rounding)
To compare two quantities::
field.Float.compare(self.product_uom_qty, self.qty_done, precision_rounding=self.product_uom_id.rounding)
The compare helper uses the __cmp__ semantics for historic purposes, therefore
the proper, idiomatic way to use this helper is like so:
if result == 0, the first and second floats are equal
if result < 0, the first float is lower than the second
if result > 0, the first float is greater than the second
"""
type = 'float'
@@ -1204,6 +1238,10 @@ class Float(Field):
return value
return ''
round = staticmethod(float_round)
is_zero = staticmethod(float_is_zero)
compare = staticmethod(float_compare)
class Monetary(Field):
""" The decimal precision and currency symbol are taken from the attribute