pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] web: lost sign between -1 and 0

Browse Source 
Create a credit note for an amount between 0 and 1, confirm it.
In Accounting app, open Reporting -> Invoice Analysis
Switch to Pivot View
The credit note amount will be positive

This occur because in `insertThousandsSep` the number -0 is converted
to "0" (string), thus losing the sign before saving it

opw-2759964

closes odoo/odoo#84946

X-original-commit: c71d4c2349e623a4bcc49c2318fbbc9de08e0fa4
Signed-off-by: Grazioso Andrea (agr) <agr@odoo.com>
This commit is contained in:
Andrea Grazioso (agr-odoo)
2022-02-21 10:28:28 +00:00
parent f561d2a95c
commit a358096aec
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/web/static/src/fields/formatters.js
+7 -7
View File
@@ -15,7 +15,7 @@ import { session } from "@web/session";
* Inserts "thousands" separators in the provided number.
*
* @private
* @param {number} number integer number
* @param {string} string representing integer number
* @param {string} [thousandsSep=","] the separator to insert
* @param {number[]} [grouping=[3,0]]
* array of relative offsets at which to insert `thousandsSep`.
@@ -23,10 +23,9 @@ import { session } from "@web/session";
* @returns {string}
*/
function insertThousandsSep(number, thousandsSep = ",", grouping = [3, 0]) {
let numStr = `${number}`;
const negative = numStr[0] === "-";
numStr = negative ? numStr.slice(1) : numStr;
return (negative ? "-" : "") + intersperse(numStr, grouping, thousandsSep);
const negative = number[0] === "-";
number = negative ? number.slice(1) : number;
return (negative ? "-" : "") + intersperse(number, grouping, thousandsSep);
}
/**
@@ -77,8 +76,9 @@ function humanNumber(number, options = { decimals: 0, minDigits: 1 }) {
// determine if we should keep the decimals (we don't want to display 1,020.02k for 1020020)
const decimalsToKeep = number >= 1000 ? 0 : decimals;
number = sign * number;
const [integerPart, decimalPart] = number.toFixed(decimalsToKeep).split(".");
const int = insertThousandsSep(sign * Number(integerPart), thousandsSep, grouping);
const int = insertThousandsSep(integerPart, thousandsSep, grouping);
if (!decimalPart) {
return int + symbol;
}
@@ -129,7 +129,7 @@ export function formatFloat(value, options = {}) {
precision = 2;
}
const formatted = (value || 0).toFixed(precision || 2).split(".");
formatted[0] = insertThousandsSep(+formatted[0], thousandsSep, grouping);
formatted[0] = insertThousandsSep(formatted[0], thousandsSep, grouping);
if (options.noTrailingZeros) {
formatted[1] = formatted[1].replace(/0+$/, "");
}
addons/web/static/tests/fields/formatters_tests.js
+2
View File
@@ -30,6 +30,8 @@ QUnit.module("Fields", (hooks) => {
assert.strictEqual(formatFloat(106500, options), "1€06€500?00");
assert.strictEqual(formatFloat(1500, { thousandsSep: "" }), "1500.00");
assert.strictEqual(formatFloat(-1.01), "-1.01");
assert.strictEqual(formatFloat(-0.01), "-0.01");
assert.strictEqual(formatFloat(38.0001, { noTrailingZeros: true }), "38");
assert.strictEqual(formatFloat(38.1, { noTrailingZeros: true }), "38.1");