[FIX] web: don't display nocontent helper if no help message

Without help message, it looks silly
This commit is contained in:
Géry Debongnie
2017-04-11 19:44:38 +02:00
committed by Aaron Bohy
parent 2d2e9c93c3
commit 9fb1228b6c
2 changed files with 27 additions and 1 deletions
@@ -210,7 +210,7 @@ var AbstractController = Widget.extend({
* @param {boolean} hasNoContent
*/
_toggleNoContentHelper: function (hasNoContent) {
if (hasNoContent) {
if (hasNoContent && this.noContentHelp) {
this.renderer.$el.detach();
var $msg = $('<div>')
.addClass('oe_view_nocontent')
@@ -735,6 +735,27 @@ QUnit.module('Views', {
list.destroy();
});
QUnit.test('no nocontent helper when no data and no help', function (assert) {
assert.expect(3);
this.data.foo.records = [];
var list = createView({
View: ListView,
model: 'foo',
data: this.data,
arch: '<tree><field name="foo"/></tree>',
});
assert.strictEqual(list.$('.oe_view_nocontent').length, 0,
"should not display the no content helper");
assert.strictEqual(list.$('tr.o_data_row').length, 0,
"should not have any data row");
assert.strictEqual(list.$('table').length, 1, "should have a table in the dom");
list.destroy();
});
QUnit.test('list view, editable, without data', function (assert) {
assert.expect(9);
@@ -752,6 +773,11 @@ QUnit.module('Views', {
'<field name="m2o"/>' +
'<field name="foo"/>' +
'</tree>',
viewOptions: {
action: {
help: '<p class="hello">click to add a partner</p>'
}
},
mockRPC: function (route, args) {
if (args.method === 'create') {
assert.ok(true, "should have created a record");