pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] sale_timesheet: fix access right error while opening sale order

Browse Source 
Purpose of this commit to fix access right error while user try
to open sale order when he has no acces right of timesheet.

So, In this commit improve code for timesheet_total_duration
compute method to directly compute timesheet_total_duration
from unit_amount of timesheets without any access right.

closes odoo/odoo#75272

Taskid: 2514517
X-original-commit: 2f7c5020cdd2073dc55ecda40d45f30c42e508e8
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
This commit is contained in:
Kartik Chavda
2021-08-18 15:30:44 +00:00
committed by Yannick Tivisse
parent d9e3aab69b
commit 9f519c44b3
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/sale_timesheet/models/sale_order.py
+10 -8
View File
@@ -40,16 +40,18 @@ class SaleOrder(models.Model):
'timesheet_count': timesheet_count,
})
@api.depends('timesheet_ids', 'company_id.timesheet_encode_uom_id')
@api.depends('company_id.project_time_mode_id', 'timesheet_ids', 'company_id.timesheet_encode_uom_id')
def _compute_timesheet_total_duration(self):
if not self.user_has_groups('hr_timesheet.group_hr_timesheet_user'):
self.update({'timesheet_total_duration': 0})
return
group_data = self.env['account.analytic.line'].sudo().read_group([
('order_id', 'in', self.ids)
], ['order_id', 'unit_amount'], ['order_id'])
timesheet_unit_amount_dict = defaultdict(float)
timesheet_unit_amount_dict.update({data['order_id'][0]: data['unit_amount'] for data in group_data})
for sale_order in self:
timesheets = sale_order.timesheet_ids if self.user_has_groups('hr_timesheet.group_hr_timesheet_approver') else sale_order.timesheet_ids.filtered(lambda t: t.user_id.id == self.env.uid)
total_time = 0.0
for timesheet in timesheets:
# Timesheets may be stored in a different unit of measure, so first we convert all of them to the reference unit
total_time += timesheet.unit_amount * timesheet.product_uom_id.factor_inv
# Now convert to the proper unit of measure
total_time *= sale_order.timesheet_encode_uom_id.factor
total_time = sale_order.company_id.project_time_mode_id._compute_quantity(timesheet_unit_amount_dict[sale_order.id], sale_order.timesheet_encode_uom_id)
sale_order.timesheet_total_duration = round(total_time)
def _compute_field_value(self, field):