pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] account : add round to payment term line sum

Browse Source 
The sum of floating points in not correct when we add a number of lines in payment term. The sum comes up to be 99.999999993 or close to this depending upon the number of lines.

1. Create payment term with 15 lines having percent payment  value of 0.166.
2. Keep the last line as calculated by the app.
3. Try to save the payment term.

Current Behavior:
A validation issue would arise stating the sum should be equal to 100.

Expected Behavior:
The payment term should be saved.

OPW-3450723

closes odoo/odoo#131126

X-original-commit: faebcd0fade95dcdbe1b70449ca46cb7e03f9926
Signed-off-by: Laurent Smet (las) <las@odoo.com>
This commit is contained in:
Hamza (hisl)
2023-08-07 20:59:16 +02:00
parent 627259e0da
commit 9bd2e29dc8
2 changed files with 38 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/account/models/account_payment_term.py
+4 -1
View File
@@ -3,6 +3,7 @@
from odoo import api, fields, models, _, Command
from odoo.exceptions import UserError, ValidationError
from odoo.tools import format_date, formatLang, frozendict, date_utils
from odoo.tools.float_utils import float_round
from dateutil.relativedelta import relativedelta
@@ -137,8 +138,10 @@ class AccountPaymentTerm(models.Model):
@api.constrains('line_ids')
def _check_lines(self):
round_precision = self.env['decimal.precision'].precision_get('Payment Terms')
for terms in self:
if sum(line.value_amount for line in terms.line_ids if line.value == 'percent') != 100:
total_percent = sum(line.value_amount for line in terms.line_ids if line.value == 'percent')
if float_round(total_percent, precision_digits=round_precision) != 100:
raise ValidationError(_('The Payment Term must have at least one percent line and the sum of the percent must be 100%.'))
if len(terms.line_ids) > 1 and terms.early_discount:
raise ValidationError(
addons/account/tests/test_payment_term.py
+34
View File
@@ -369,3 +369,37 @@ class TestAccountPaymentTerms(AccountTestInvoicingCommon):
[self.env.company.currency_id.round(l['foreign_amount']) for l in computed_term['line_ids']],
[700.0, 500.0, 300.0, -500.0],
)
def test_payment_term_percent_round_calculation(self):
"""
the sum function might not sum the floating numbers properly
if there are a lot of lines with floating numbers
so this test verifies the round function changes
"""
self.env['account.payment.term'].create({
'name': "test_payment_term_percent_round_calculation",
'line_ids': [
Command.create({'value_amount': 50, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 1.66, 'value': 'percent', 'nb_days': 0, }),
Command.create({'value_amount': 16.8, 'value': 'percent', 'nb_days': 0, }),
],
})