pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[IMP] mail: remove _updateChatterContainerTarget

Browse Source 
It is only called inside `_interchangeChatter`, therefore its code can be moved.

Part of task-2871070

Part-of: odoo/odoo#95218
This commit is contained in:
Sébastien Theys
2022-07-04 18:53:21 +02:00
parent 7fd20304ea
commit 935ca62a1f
1 changed files with 22 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/mail/static/src/widgets/form_renderer/form_renderer.js
+22 -23
View File
@@ -156,14 +156,31 @@ FormRenderer.include({
*/
_interchangeChatter() {
const $sheetBg = this.$('.o_form_sheet_bg');
this._updateChatterContainerTarget();
if (this._isChatterAside()) {
this._chatterContainerTarget.classList.add('o-aside');
this._chatterContainerTarget.classList.remove('o-isInFormSheetBg');
$(this._chatterContainerTarget).insertAfter($sheetBg);
} else if (this.isChatterInSheet) {
const $sheet = this.$('.o_form_sheet');
dom.append($sheet, $(this._chatterContainerTarget));
} else {
dom.append($sheetBg, $(this._chatterContainerTarget));
this._chatterContainerTarget.classList.remove('o-aside');
if (this.isChatterInSheet) {
this._chatterContainerTarget.classList.remove('o-isInFormSheetBg');
const $sheet = this.$('.o_form_sheet');
dom.append($sheet, $(this._chatterContainerTarget), {
callbacks: [],
in_DOM: this._isInDom,
});
} else {
if (this.hasAttachmentViewer()) {
this._chatterContainerTarget.classList.add('o-isInFormSheetBg');
dom.append($sheetBg, $(this._chatterContainerTarget), {
callbacks: [],
in_DOM: this._isInDom,
});
} else {
this._chatterContainerTarget.classList.remove('o-isInFormSheetBg');
$(this._chatterContainerTarget).insertAfter($sheetBg);
}
}
}
if (this.hasAttachmentViewer()) {
$(this.attachmentViewerTarget).insertAfter($sheetBg);
@@ -213,24 +230,6 @@ FormRenderer.include({
}
}
},
/**
* Add a class to allow styling of chatter depending on the fact is is
* printed aside or underneath the form sheet.
*
* @private
*/
_updateChatterContainerTarget() {
if (this._isChatterAside()) {
this._chatterContainerTarget.classList.add('o-aside');
} else {
this._chatterContainerTarget.classList.remove('o-aside');
}
if (this.hasAttachmentViewer()) {
this._chatterContainerTarget.classList.add('o-isInFormSheetBg');
} else {
this._chatterContainerTarget.classList.remove('o-isInFormSheetBg');
}
},
/**
* @private
* @param {OdooEvent} ev