pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] Remove bad aria-hidden (#25481)

Browse Source 
Some aria-hidden are present on some elements that must be visible. Some dialogs don't open correctly with this.
This commit is contained in:
kujiu
2018-06-28 12:31:27 +02:00
committed by GitHub
parent 99c29c37f8
commit 92bf89ffb3
8 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/account/views/account_portal_templates.xml
+2 -2
View File
@@ -121,11 +121,11 @@
<template id="portal_invoice_chatter" name="Allow Comments &amp; History" inherit_id="account.portal_invoice_page">
<xpath expr="//div[@id='invoice_content']//div[hasclass('o_portal_html_view')]" position="after">
<div class="modal fade" id="invoice_chatter" role="dialog" aria-hidden="true">
<div class="modal fade" id="invoice_chatter" role="dialog">
<div class="modal-dialog">
<div class="modal-content">
<div class="modal-header">
<button type="button" class="close" data-dismiss="modal" aria-hidden="true">&amp;times;</button>
<button type="button" class="close" data-dismiss="modal">&amp;times;</button>
<h3 class="mt0 ml16 mb0">History</h3>
</div>
<div class="modal-body">
addons/account_payment/views/account_portal_templates.xml
+2 -2
View File
@@ -37,11 +37,11 @@
<template id="portal_invoice_payment" name="Invoice Payment">
<div class="row" t-if="not tx_ids and invoice.state == 'open' and invoice.amount_total" id="portal_pay">
<div class="modal fade" id="pay_with" role="dialog" aria-hidden="true">
<div class="modal fade" id="pay_with" role="dialog">
<div class="modal-dialog modal-content">
<div class="modal-content">
<div class="modal-header">
<button type="button" class="close" data-dismiss="modal" aria-hidden="true">&amp;times;</button>
<button type="button" class="close" data-dismiss="modal">&amp;times;</button>
<h3 class="modal-title">Pay with</h3>
</div>
<div class="modal-footer">
addons/website/views/website_templates.xml
+1 -1
View File
@@ -739,7 +739,7 @@
</script>
</head>
<body>
<div role="dialog" id="reset_template_confirmation" class="modal" tabindex="-1" aria-hidden="true" t-ignore="true">
<div role="dialog" id="reset_template_confirmation" class="modal" tabindex="-1" t-ignore="true">
<div class="modal-dialog">
<form class="form-horizontal" role="form">
<div class="modal-content">
addons/website_crm_partner_assign/views/website_crm_partner_assign_templates.xml
+5 -5
View File
@@ -265,7 +265,7 @@
<t t-set="title">My Opportunities</t>
<li class="pull-left"><button t-if="request.env.user.partner_id.grade_id or request.env.user.commercial_partner_id.grade_id" name='new_opp' data-toggle="modal" data-target=".modal_new_opp" class="btn btn-default navbar-btn ml16" title="Add an opportunity" aria-label="Add an opportunity"><i class="fa fa-plus"/></button></li>
</t>
<div class="modal fade modal_new_opp" role="form" aria-hidden="true">
<div class="modal fade modal_new_opp" role="form">
<div class="modal-dialog">
<form method="POST" class="modal-content js_website_submit_form new_opp_form">
<input type="hidden" name="csrf_token" t-att-value="request.csrf_token()"/>
@@ -423,7 +423,7 @@
<div>
<a role="button" class="btn btn-primary btn" data-toggle="modal" data-target=".modal_partner_assign_interested"><span class="fa fa-file-text-o"> I'm interested</span></a>
<a role="button" class="btn btn-primary btn" data-toggle="modal" data-target=".modal_partner_assign_desinterested"><span class="fa fa-fw fa-times"> I'm not interested</span></a>
<div role="dialog" class="modal fade modal_partner_assign_interested" aria-hidden="true">
<div role="dialog" class="modal fade modal_partner_assign_interested">
<div class="modal-dialog">
<form method="POST" class="js_accept_json modal-content js_website_submit_form interested_partner_assign_form">
<input type="hidden" name="csrf_token" t-att-value="request.csrf_token()"/>
@@ -452,7 +452,7 @@
</form>
</div>
</div>
<div role="dialog" class="modal fade modal_partner_assign_desinterested" aria-hidden="true">
<div role="dialog" class="modal fade modal_partner_assign_desinterested">
<div class="modal-dialog">
<form method="POST" class="js_accept_json modal-content js_website_submit_form desinterested_partner_assign_form">
<input type="hidden" name="csrf_token" t-att-value="request.csrf_token()"/>
@@ -537,7 +537,7 @@
<div class="col-md-6">
<div>
<button type="button" data-toggle="modal" data-target=".modal_edit_contact" class="btn btn-sm btn-primary" style="margin-bottom: 10px;">Edit Contact</button>
<div role="dialog" class="modal fade modal_edit_contact" aria-hidden="true">
<div role="dialog" class="modal fade modal_edit_contact">
<div class="modal-dialog">
<form method="POST" class="js_accept_json modal-content js_website_submit_form edit_contact_form">
<input type="hidden" name="csrf_token" t-att-value="request.csrf_token()"/>
@@ -652,7 +652,7 @@
<div class="col-md-6">
<div>
<button type="button" data-toggle="modal" data-target=".modal_edit_opp" class="btn btn-sm btn-primary" style="margin-bottom: 10px;">Edit Opportunity</button>
<div role="dialog" class="modal fade modal_edit_opp" aria-hidden="true">
<div role="dialog" class="modal fade modal_edit_opp">
<div class="modal-dialog">
<form method="POST" class="js_accept_json modal-content js_website_submit_form edit_opp_form">
<input type="hidden" name="csrf_token" t-att-value="request.csrf_token()"/>
addons/website_mass_mailing/views/snippets_templates.xml
+1 -1
View File
@@ -32,7 +32,7 @@
<div class="alert alert-warning alert-dismissible fade in css_non_editable_mode_hidden o_not_editable" role="status">
<strong>Newsletter Popup!</strong> The newsletter popup snippet effect is active on this page. Click <a id="edit_dialog" href="#">Here To Edit Dialog Content</a>
</div>
<div role="dialog" class="modal modal-dialog modal-md fade fade-custom" id="o_newsletter_popup" tabindex="-1" aria-hidden="true">
<div role="dialog" class="modal modal-dialog modal-md fade fade-custom" id="o_newsletter_popup" tabindex="-1">
<div class="modal-content o_popup_modal_content">
<a role="button" href="#" class="o_popup_btn_close o_not_editable" data-dismiss="modal">&amp;times;</a>
addons/website_membership/views/website_membership_templates.xml
+1 -1
View File
@@ -98,7 +98,7 @@
<xpath expr="//div[@id='left_column']/ul[last()]" position="after">
<t t-if="google_maps_api_key">
<!-- modal for large map -->
<div role="dialog" class="modal fade partner_map_modal" tabindex="-1" aria-hidden="true">
<div role="dialog" class="modal fade partner_map_modal" tabindex="-1">
<div class="modal-dialog modal-lg">
<div class="modal-content">
<header class="modal-header">
addons/website_quote/views/website_quote_templates.xml
+2 -2
View File
@@ -300,7 +300,7 @@
</div>
<!-- modal relative to the actions Accept/Reject/Cancel -->
<div role="dialog" class="modal fade" id="modalaccept" aria-hidden="true">
<div role="dialog" class="modal fade" id="modalaccept">
<div class="modal-dialog" t-if="not quotation.require_payment and not need_payment">
<form id="accept" method="POST" t-att-data-order-id="quotation.id" t-att-data-token="quotation.access_token" class="js_accept_json modal-content js_website_submit_form">
<input type="hidden" name="csrf_token" t-att-value="request.csrf_token()"/>
@@ -356,7 +356,7 @@
</div>
</div>
<div role="dialog" class="modal fade" id="modaldecline" aria-hidden="true">
<div role="dialog" class="modal fade" id="modaldecline">
<div class="modal-dialog">
<form id="decline" method="POST" t-attf-action="/quote/#{quotation.id}/#{quotation.access_token}/decline" class="modal-content">
<input type="hidden" name="csrf_token" t-att-value="request.csrf_token()"/>
odoo/addons/base/views/res_users_views.xml
+1 -1
View File
@@ -163,7 +163,7 @@
</button>
</div>
<div class="alert alert-info text-center o_form_header" attrs="{'invisible': [('active', '=', True)]}" role="alert">
<a class="close" data-dismiss="alert" href="#" aria-hidden="true">x</a>
<a class="close" data-dismiss="alert" href="#">x</a>
<div>
<strong>The contact linked to this user is still active</strong>
</div>