[FIX] web: BS4, review selected dropdown item style (II)

Completes commit https://github.com/odoo/odoo/commit/e10a4303c21332f10d89b0c19661cc11ca0dc7a6

addons/web/static/src/scss/dropdown_menu.scss

@@ -1,5 +1,4 @@
 .o_dropdown_menu {
-
     > .dropdown-divider:first-child {
         display: none;
     }
@@ -22,3 +21,24 @@
         }
     }
 }
+
+.dropdown-item {
+    position: relative;
+    color: $o-main-text-color;
+
+    &:hover {
+        color: darken($o-main-text-color, 10%);
+    }
+
+    &.selected { // TODO why not using standard BS4 "active" class ?
+        color: darken($o-main-text-color, 10%);
+        font-weight: bold;
+
+        &:before {
+            font-family: FontAwesome;
+            position: absolute;
+            left: 4px;
+            content: "\f00c";
+        }
+    }
+}

addons/web/static/src/scss/graph_view.scss

@@ -11,10 +11,3 @@
 .nvtooltip thead {
     background-color: transparent;
 }
-
-// ------------------------------------------------------------------
-// Control panel buttons
-// ------------------------------------------------------------------
-.o_graph_measures_list, .o_graph_groupbys_list {
-    @include o-selected-li;
-}

addons/web/static/src/scss/pivot_view.scss

@@ -69,10 +69,3 @@
         top: 9px;
     }
 }
-
-// ------------------------------------------------------------------
-// Control panel buttons
-// ------------------------------------------------------------------
-.o_pivot_measures_list {
-    @include o-selected-li;
-}

addons/web/static/src/scss/search_view.scss

@@ -143,8 +143,6 @@
 
 // Filters
 .o_filters_menu {
-    @include o-selected-li;
-
     max-height: calc(100vh - 125px);
     overflow: auto;
 
@@ -189,7 +187,6 @@
 .o_favorites_menu {
     max-height: 75vh;
     overflow-y: auto;
-    @include o-selected-li;
 
     max-height: calc(100vh - 125px);
     overflow: auto;

addons/web/static/src/scss/utils.scss

@@ -105,30 +105,6 @@
     -moz-transform: scale(0.9999); // Smooth the caret on firefox
 }
 
-// ------------------------------------------------------------------
-// Dropdowns
-// ------------------------------------------------------------------
-@mixin o-selected-li { // FIXME use active ?
-    .dropdown-item {
-        position: relative;
-        color: $o-main-text-color;
-        &:hover {
-            color: darken($o-main-text-color, 10%);
-        }
-
-        &.selected {
-            color: darken($o-main-text-color, 10%);
-            font-weight: bold;
-            &:before {
-                font-family: FontAwesome;
-                position: absolute;
-                left: 4px;
-                content: "\f00c";
-            }
-        }
-    }
-}
-
 // ------------------------------------------------------------------
 // Hovering effects
 // ------------------------------------------------------------------