pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] stock_landed_cost : traceback division by 0 when no quantity

Browse Source 
Issue: When computing the landed cost for a transfer with quantity 0,
the validation of the LC wasn't working since there was a quantity 0

Steps to reproduce :
 1) Create a PO for some items
 2) Confirm, validate the delivery
 3) Edit and unlock the delivery, set one quantity to 0, save
 4) Create a landed cost for that transfer
 5) Compute it
 6) Validate -> Traceback

Why is that a bug:
 There should not be a traceback, this is caused by trying to validate
 a landed cost for a product where there is no quantity, if there is no
 quantity, it should be part of the landed cost computation

opw-2599799

closes odoo/odoo#75565

X-original-commit: 800433bde03a36ead40a78bc6d53cbb95c24f97b
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
Signed-off-by: Nathan Marotte <nmarotte@users.noreply.github.com>
This commit is contained in:
Nathan Marotte (nama)
2021-08-27 09:33:58 +00:00
parent 58d0db2017
commit 875bcb1d66
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/stock_landed_costs/models/stock_landed_cost.py
+1 -1
View File
@@ -184,7 +184,7 @@ class StockLandedCost(models.Model):
for move in self._get_targeted_move_ids():
# it doesn't make sense to make a landed cost for a product that isn't set as being valuated in real time at real cost
if move.product_id.valuation != 'real_time' or move.product_id.cost_method not in ('fifo', 'average') or move.state == 'cancel':
if move.product_id.valuation != 'real_time' or move.product_id.cost_method not in ('fifo', 'average') or move.state == 'cancel' or not move.product_qty:
continue
vals = {
'product_id': move.product_id.id,