pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[REF] web_editor: remove unused variable

Browse Source 
The `hasSearch` variable on `this` was not used anywhere and, if it was,
its semantic was arguable because it was set true as soon as the search
was fired rather than when the search had returned.

I'm taking this opportunity to use async/await as it's *way* better here.

closes odoo/odoo#92014

Signed-off-by: Romain Derie (rde) <rde@odoo.com>
This commit is contained in:
David Monjoie
2022-05-23 13:04:52 +02:00
parent 4fb98f767a
commit 87563f875c
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/web_editor/static/src/js/wysiwyg/widgets/media.js
+5 -8
View File
@@ -118,17 +118,14 @@ var SearchableMediaWidget = MediaWidget.extend({
/**
* @private
*/
_onSearchInput: function (ev) {
_onSearchInput: async function (ev) {
this.attachments = [];
// Disable user interactions with attachments while updating results.
this.$('.o_we_existing_attachments').css('pointer-events', 'none');
this.search($(ev.currentTarget).val() || "")
.then(() => this._renderThumbnails())
.then(() => {
// Re-enable user interactions after updating results.
this.$(".o_we_existing_attachments").css("pointer-events", "");
});
this.hasSearched = true;
await this.search($(ev.currentTarget).val() || '');
await this._renderThumbnails();
// Re-enable user interactions with attachments after updating results.
this.$('.o_we_existing_attachments').css('pointer-events', '');
},
});