pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] hr_holidays: Avoid useless check_validity calls on payslip computation

Browse Source 
closes odoo/odoo#152311

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
This commit is contained in:
Yannick Tivisse
2024-02-02 19:49:40 +00:00
parent 9b44161ad9
commit 86891b8e08
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/hr_holidays/models/hr_leave.py
+7 -4
View File
@@ -783,7 +783,7 @@ Attempting to double-book your time off won't magically make your vacation 2x be
if leave_type.allows_negative:
max_excess = leave_type.max_allowed_negative
for employee in employees:
if leave_data[employee][0][1]['virtual_remaining_leaves'] < -max_excess:
if leave_data[employee] and leave_data[employee][0][1]['virtual_remaining_leaves'] < -max_excess:
raise ValidationError(_("There is no valid allocation to cover that request."))
continue
@@ -791,8 +791,10 @@ Attempting to double-book your time off won't magically make your vacation 2x be
ignored_leave_ids=leaves.ids
).get_allocation_data(employees, date_from)
for employee in employees:
previous_emp_data = previous_leave_data[employee][0][1]['virtual_excess_data']
emp_data = leave_data[employee][0][1]['virtual_excess_data']
previous_emp_data = previous_leave_data[employee] and previous_leave_data[employee][0][1]['virtual_excess_data']
emp_data = leave_data[employee] and leave_data[employee][0][1]['virtual_excess_data']
if not previous_emp_data and not emp_data:
continue
if previous_emp_data != emp_data and len(emp_data) >= len(previous_emp_data):
raise ValidationError(_("There is no valid allocation to cover that request."))
@@ -990,7 +992,8 @@ Attempting to double-book your time off won't magically make your vacation 2x be
if 'date_to' in values:
values['request_date_to'] = values['date_to']
result = super(HolidaysRequest, self).write(values)
self._check_validity()
if any(field in values for field in ['request_date_from', 'date_from', 'request_date_from', 'date_to', 'holiday_status_id', 'employee_id']):
self._check_validity()
if not self.env.context.get('leave_fast_create'):
for holiday in self:
if employee_id: