pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] web: fix bus of loading indicator

Browse Source 
We do not clean the event handlers properly (because we do .bind()).
So we have another version of the handlers and they are not unbinded.
In this commit, to remedy this, we use the useBus function which
resolves this problem.

closes odoo/odoo#137885

X-original-commit: 7e2e2e0b257d44ce051a3ee8f60e9e03f5d14739
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
This commit is contained in:
Pierre Pulinckx (pipu)
2023-10-06 17:11:27 +00:00
parent c2a98bf2e8
commit 844448320d
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/web/static/src/webclient/loading_indicator/loading_indicator.js
+4 -8
View File
@@ -2,10 +2,10 @@
import { browser } from "@web/core/browser/browser";
import { registry } from "@web/core/registry";
import { useService } from "@web/core/utils/hooks";
import { useBus, useService } from "@web/core/utils/hooks";
import { Transition } from "@web/core/transition";
import { Component, onWillDestroy, useState } from "@odoo/owl";
import { Component, useState } from "@odoo/owl";
/**
* Loading Indicator
@@ -28,12 +28,8 @@ export class LoadingIndicator extends Component {
this.shouldUnblock = false;
this.startShowTimer = null;
this.blockUITimer = null;
this.env.bus.addEventListener("RPC:REQUEST", this.requestCall.bind(this));
this.env.bus.addEventListener("RPC:RESPONSE", this.responseCall.bind(this));
onWillDestroy(() => {
this.env.bus.removeEventListener("RPC:REQUEST", this.requestCall.bind(this));
this.env.bus.removeEventListener("RPC:RESPONSE", this.responseCall.bind(this));
});
useBus(this.env.bus, "RPC:REQUEST", this.requestCall);
useBus(this.env.bus, "RPC:RESPONSE", this.responseCall);
}
requestCall({ detail }) {