pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[IMP] product: price computation performance

Browse Source 
This commit improves the performance of `_is_applicable_for`, by:

1) Leveraging the `product.category.parent_path` field.
2) Use `applied_on` for the `if` conditions, which is ~100% faster than using
   the many2one fields due to the related record initialization.

These micro-optimizations are important because of the way `_is_applicable_for`
is used.

See: https://github.com/odoo/odoo/blob/0a5d84289/addons/product/models/product_pricelist.py#L169-L193

Which, for demostration purposes, could be simplified to:

```
for product, qty, partner in products_qty_partner:
    for rule in items:
        if not rule._is_applicable_for(product, qty_in_product_uom):
            continue
```

On a database with 470 products, and about the same number of pricelist items,
these optimization result in a ~30% speedup when computing prices for all
products at once. It may be even better depending on how many nested product
categories are used in the database and in the pricelist rules.

closes odoo/odoo#125670

X-original-commit: 3619f77c73092e800aab10f0df09ca5775545da3
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
This commit is contained in:
Ivàn Todorovich
2023-06-20 00:24:03 +02:00
committed by Victor Feyens
parent 9c753b01c9
commit 800147ce9f
1 changed files with 9 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/product/models/product_pricelist_item.py
+9 -12
View File
@@ -319,30 +319,27 @@ class PricelistItem(models.Model):
if self.min_quantity and qty_in_product_uom < self.min_quantity:
res = False
elif self.categ_id:
# Applied on a specific category
cat = product.categ_id
while cat:
if cat.id == self.categ_id.id:
break
cat = cat.parent_id
if not cat:
elif self.applied_on == "2_product_category":
if (
product.categ_id != self.categ_id
and not product.categ_id.parent_path.startswith(self.categ_id.parent_path)
):
res = False
else:
# Applied on a specific product template/variant
if is_product_template:
if self.product_tmpl_id and product.id != self.product_tmpl_id.id:
if self.applied_on == "1_product" and product.id != self.product_tmpl_id.id:
res = False
elif self.product_id and not (
elif self.applied_on == "0_product_variant" and not (
product.product_variant_count == 1
and product.product_variant_id.id == self.product_id.id
):
# product self acceptable on template if has only one variant
res = False
else:
if self.product_tmpl_id and product.product_tmpl_id.id != self.product_tmpl_id.id:
if self.applied_on == "1_product" and product.product_tmpl_id.id != self.product_tmpl_id.id:
res = False
elif self.product_id and product.id != self.product_id.id:
elif self.applied_on == "0_product_variant" and product.id != self.product_id.id:
res = False
return res