pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] web: failing quick create in m2o inside x2m

Browse Source 
Write something in a many2one field, and click on 'Create "..."'
to quick create a record with the given value (name_create). When
the name_create fails (e.g. because there are mandatory fields in
the model), we open a form view.

Before this commit, when this happened for many2one fields inside
x2many editable lists, it crashed, since [1].

[1] 50bf8309f8

closes odoo/odoo#50948

X-original-commit: 43c513306094444ff25ad98584b426ddb8a3b525
Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
This commit is contained in:
Aaron Bohy
2020-05-08 15:38:06 +00:00
parent 2344198765
commit 8000e895cd
2 changed files with 76 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/web/static/src/js/fields/relational_fields.js
+2 -2
View File
@@ -1548,9 +1548,9 @@ var FieldX2Many = AbstractField.extend(WidgetAdapterMixin, {
if (ev.data.onSuccess) {
ev.data.onSuccess();
}
}).guardedCatch(function () {
}).guardedCatch(function (reason) {
if (ev.data.onFailure) {
ev.data.onFailure();
ev.data.onFailure(reason);
}
});
}
addons/web/static/tests/fields/relational_fields/field_many2one_tests.js
+74
View File
@@ -2212,6 +2212,80 @@ QUnit.module('fields', {}, function () {
form.destroy();
});
QUnit.test('failing quick create on a many2one', async function (assert) {
assert.expect(4);
const form = await createView({
View: FormView,
model: 'partner',
data: this.data,
arch: '<form><field name="product_id"/></form>',
archs: {
'product,false,form': '<form><field name="name"/></form>',
},
mockRPC(route, args) {
if (args.method === 'name_create') {
return Promise.reject();
}
if (args.method === 'create') {
assert.deepEqual(args.args[0], { name: 'xyz' });
}
return this._super(...arguments);
},
});
await testUtils.fields.many2one.searchAndClickItem('product_id', {
search: 'abcd',
item: 'Create "abcd"',
});
assert.containsOnce(document.body, '.modal .o_form_view');
assert.strictEqual($('.o_field_widget[name=name]').val(), 'abcd');
await testUtils.fields.editInput($('.modal .o_field_widget[name=name]'), 'xyz');
await testUtils.dom.click($('.modal .modal-footer .btn-primary'));
assert.strictEqual(form.$('.o_field_widget[name=product_id] input').val(), 'xyz');
form.destroy();
});
QUnit.test('failing quick create on a many2one inside a one2many', async function (assert) {
assert.expect(4);
const form = await createView({
View: FormView,
model: 'partner',
data: this.data,
arch: '<form><field name="p"/></form>',
archs: {
'partner,false,list': '<tree editable="bottom"><field name="product_id"/></tree>',
'product,false,form': '<form><field name="name"/></form>',
},
mockRPC(route, args) {
if (args.method === 'name_create') {
return Promise.reject();
}
if (args.method === 'create') {
assert.deepEqual(args.args[0], { name: 'xyz' });
}
return this._super(...arguments);
},
});
await testUtils.dom.click(form.$('.o_field_x2many_list_row_add a'));
await testUtils.fields.many2one.searchAndClickItem('product_id', {
search: 'abcd',
item: 'Create "abcd"',
});
assert.containsOnce(document.body, '.modal .o_form_view');
assert.strictEqual($('.o_field_widget[name=name]').val(), 'abcd');
await testUtils.fields.editInput($('.modal .o_field_widget[name=name]'), 'xyz');
await testUtils.dom.click($('.modal .modal-footer .btn-primary'));
assert.strictEqual(form.$('.o_field_widget[name=product_id] input').val(), 'xyz');
form.destroy();
});
QUnit.test('slow create on a many2one', async function (assert) {
assert.expect(11);