Revert "[FIX] models: in onchange, add missing fields when comparing values"

This reverts commit 882bbf46e2.

This revision leads to a crash when creating a new user:

Traceback (most recent call last):
  File "/home/dle/odoo/9/openerp/http.py", line 643, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/home/dle/odoo/9/openerp/http.py", line 680, in dispatch
    result = self._call_function(**self.params)
  File "/home/dle/odoo/9/openerp/http.py", line 316, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/home/dle/odoo/9/openerp/service/model.py", line 118, in wrapper
    return f(dbname, *args, **kwargs)
  File "/home/dle/odoo/9/openerp/http.py", line 309, in checked_call
    result = self.endpoint(*a, **kw)
  File "/home/dle/odoo/9/openerp/http.py", line 959, in __call__
    return self.method(*args, **kw)
  File "/home/dle/odoo/9/openerp/http.py", line 509, in response_wrap
    response = f(*args, **kw)
  File "/home/dle/odoo/enterprise-9/web/controllers/main.py", line 907, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/home/dle/odoo/enterprise-9/web/controllers/main.py", line 899, in _call_kw
    return getattr(request.registry.get(model), method)(request.cr, request.uid, *args, **kwargs)
  File "/home/dle/odoo/9/openerp/api.py", line 238, in wrapper
    return old_api(self, *args, **kwargs)
  File "/home/dle/odoo/9/openerp/api.py", line 369, in old_api
    result = method(recs, *args, **kwargs)
  File "/home/dle/odoo/9/openerp/models.py", line 5998, in onchange
    record.mapped(name)
  File "/home/dle/odoo/9/openerp/models.py", line 5497, in mapped
    recs = recs._mapped_func(operator.itemgetter(name))
  File "/home/dle/odoo/9/openerp/models.py", line 5477, in _mapped_func
    vals = [func(rec) for rec in self]
  File "/home/dle/odoo/9/openerp/models.py", line 5715, in __getitem__
    return self._fields[key].__get__(self, type(self))
KeyError: u'in_group_18'
This commit is contained in:
Denis Ledoux
2015-12-23 17:59:36 +01:00
parent 7021221e2e
commit 79a0d1defb
+4 -4
View File
@@ -5989,14 +5989,14 @@ class BaseModel(object):
# create a new record with values, and attach ``self`` to it
with env.do_in_onchange():
record = self.new(values)
values = dict(record._cache)
# attach ``self`` with a different context (for cache consistency)
record._origin = self.with_context(__onchange=True)
# load missing fields values, to avoid false changes
# load fields on secondary records, to avoid false changes
with env.do_in_onchange():
for name in field_onchange:
record.mapped(name)
values = dict(record._cache)
for field_seq in secondary:
record.mapped(field_seq)
# determine which field(s) should be triggered an onchange
todo = list(names) or list(values)