[FIX] hr_timesheet: select correct employee in create

Prior to this commit:

    - The employee was the first one returned through a search that
      was not taking the company into account.

After this commit:

    - The employee will be selected according to the company.

This issue arose with b5b105ea

closes odoo/odoo#81704

X-original-commit: 246caae0e70a8af0b507ba87921783a493c86064
Related: odoo/enterprise#23010
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>

addons/hr_timesheet/models/hr_timesheet.py

@@ -1,6 +1,7 @@
 # -*- coding: utf-8 -*-
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
 
+from collections import defaultdict
 from lxml import etree
 import re
 
@@ -17,7 +18,7 @@ class AccountAnalyticLine(models.Model):
         if 'encoding_uom_id' in field_list:
             result['encoding_uom_id'] = self.env.company.timesheet_encode_uom_id.id
         if not self.env.context.get('default_employee_id') and 'employee_id' in field_list and result.get('user_id'):
-            result['employee_id'] = self.env['hr.employee'].search([('user_id', '=', result['user_id'])], limit=1).id
+            result['employee_id'] = self.env['hr.employee'].search([('user_id', '=', result['user_id']), ('company_id', '=', result.get('company_id', self.env.company.id))], limit=1).id
         return result
 
     def _domain_project_id(self):
@@ -111,17 +112,25 @@ class AccountAnalyticLine(models.Model):
     def create(self, vals_list):
         default_user_id = self._default_user()
         user_ids = list(map(lambda x: x.get('user_id', default_user_id), filter(lambda x: not x.get('employee_id') and x.get('project_id'), vals_list)))
-        employees = self.env['hr.employee'].search([('user_id', 'in', user_ids)])
-        user_map = {employee.user_id.id: employee.id for employee in employees}
 
         for vals in vals_list:
             # when the name is not provide by the 'Add a line', we set a default one
             if vals.get('project_id') and not vals.get('name'):
                 vals['name'] = '/'
+            vals.update(self._timesheet_preprocess(vals))
+
+        # Although this make a second loop on the vals, we need to wait the preprocess as it could change the company_id in the vals
+        # TODO To be refactored in master
+        company_ids_in_vals = list({vals['company_id'] for vals in vals_list if vals.get('company_id', False)})
+        employees = self.env['hr.employee'].search([('user_id', 'in', user_ids), ('company_id', 'in', [self.env.company.id] + company_ids_in_vals)])
+        user_map = defaultdict(dict)
+        for employee in employees:
+            user_map[employee.company_id.id][employee.user_id.id] = employee.id
+
+        for vals in vals_list:
             # compute employee only for timesheet lines, makes no sense for other lines
             if not vals.get('employee_id') and vals.get('project_id'):
-                vals['employee_id'] = user_map.get(vals.get('user_id') or default_user_id)
-            vals.update(self._timesheet_preprocess(vals))
+                vals['employee_id'] = user_map[vals.get('company_id', self.env.company.id)].get(vals.get('user_id', default_user_id), False)
 
         lines = super(AccountAnalyticLine, self).create(vals_list)
         for line, values in zip(lines, vals_list):