pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[IMP] web: allow caching get_fonts calls in NameAndSignature

Browse Source 
In sign many NameAndSignature widgets are opened and closed since it is
expected that documents have multiple initial/signature fields. Everytime
the widget is opened, an rpc call to get_fonts is done, even if the request
has already been done before. This commit prevents this rpc call if the fonts
are already loaded.

task-2735814

closes odoo/odoo#83208

Related: odoo/enterprise#23653
Signed-off-by: Arnaud Joset <arj@odoo.com>
This commit is contained in:
Leonardo Pavan Rocha
2022-03-09 10:23:49 +00:00
parent 1f1924862e
commit 6ed159e912
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/web/static/src/legacy/js/widgets/name_and_signature.js
+9 -3
View File
@@ -84,11 +84,17 @@ var NameAndSignature = Widget.extend({
* @override
*/
willStart: function () {
var self = this;
/** LPR: in sign module, the web/sign/get_fonts call is cached since
* many NameAndSignature widgets are created. This way, we prevent
* doing the rpc call if it was already done inside sign
*/
if (this.fonts && this.fonts.length > 0) {
return this._super.apply(this, arguments);
}
return Promise.all([
this._super.apply(this, arguments),
this._rpc({route: '/web/sign/get_fonts/' + self.defaultFont}).then(function (data) {
self.fonts = data;
this._rpc({route: '/web/sign/get_fonts/' + this.defaultFont}).then(data => {
this.fonts = data;
})
]);
},