[FIX] *: useless parameter 'ondelete' on One2many fields

Note: some of them were moved to the corresponding M2O.

addons/account/models/account_payment.py

@@ -48,7 +48,7 @@ class account_payment(models.Model):
     has_invoices = fields.Boolean(compute="_compute_reconciled_invoice_ids", help="Technical field used for usability purposes")
     reconciled_invoices_count = fields.Integer(compute="_compute_reconciled_invoice_ids")
 
-    move_line_ids = fields.One2many('account.move.line', 'payment_id', readonly=True, copy=False, ondelete='restrict')
+    move_line_ids = fields.One2many('account.move.line', 'payment_id', readonly=True, copy=False)
     move_reconciled = fields.Boolean(compute="_get_move_reconciled", readonly=True)
 
     state = fields.Selection([('draft', 'Draft'), ('posted', 'Validated'), ('sent', 'Sent'), ('reconciled', 'Reconciled'), ('cancelled', 'Cancelled'), ('invoicing_legacy', 'Invoicing App Legacy')], readonly=True, default='draft', copy=False, string="Status", tracking=True)

addons/calendar/models/calendar.py

@@ -845,7 +845,7 @@ class Meeting(models.Model):
     partner_id = fields.Many2one('res.partner', string='Responsible', related='user_id.partner_id', readonly=True)
     active = fields.Boolean('Active', default=True, help="If the active field is set to false, it will allow you to hide the event alarm information without removing it.")
     categ_ids = fields.Many2many('calendar.event.type', 'meeting_category_rel', 'event_id', 'type_id', 'Tags')
-    attendee_ids = fields.One2many('calendar.attendee', 'event_id', 'Participant', ondelete='cascade')
+    attendee_ids = fields.One2many('calendar.attendee', 'event_id', 'Participant')
     partner_ids = fields.Many2many('res.partner', 'calendar_event_res_partner_rel', string='Attendees', states={'done': [('readonly', True)]}, default=_default_partners)
     alarm_ids = fields.Many2many('calendar.alarm', 'calendar_alarm_calendar_event_rel', string='Reminders', ondelete="restrict", copy=False)
     is_highlighted = fields.Boolean(compute='_compute_is_highlighted', string='Is the Event Highlighted')

addons/hr_skills/models/hr_skills.py

@@ -10,7 +10,7 @@ class Skill(models.Model):
     _description = "Skill"
 
     name = fields.Char(required=True)
-    skill_type_id = fields.Many2one('hr.skill.type')
+    skill_type_id = fields.Many2one('hr.skill.type', ondelete='cascade')
 
 
 class EmployeeSkill(models.Model):
@@ -47,7 +47,7 @@ class SkillLevel(models.Model):
     _description = "Skill Level"
     _order = "level_progress desc"
 
-    skill_type_id = fields.Many2one('hr.skill.type')
+    skill_type_id = fields.Many2one('hr.skill.type', ondelete='cascade')
     name = fields.Char(required=True)
     level_progress = fields.Integer(string="Progress", help="Progress from zero knowledge (0%) to fully mastered (100%).")
 
@@ -57,5 +57,5 @@ class SkillType(models.Model):
     _description = "Skill Type"
 
     name = fields.Char(required=True)
-    skill_ids = fields.One2many('hr.skill', 'skill_type_id', string="Skills", ondelete='cascade')
-    skill_level_ids = fields.One2many('hr.skill.level', 'skill_type_id', string="Levels", ondelete='cascade')
+    skill_ids = fields.One2many('hr.skill', 'skill_type_id', string="Skills")
+    skill_level_ids = fields.One2many('hr.skill.level', 'skill_type_id', string="Levels")

addons/lunch/models/lunch_product.py

@@ -18,9 +18,9 @@ class LunchProductCategory(models.Model):
     topping_label_1 = fields.Char('Extra 1 Label', required=True, default='Extras')
     topping_label_2 = fields.Char('Extra 2 Label', required=True, default='Beverages')
     topping_label_3 = fields.Char('Extra 3 Label', required=True, default='Extra Label 3')
-    topping_ids_1 = fields.One2many('lunch.topping', 'category_id', domain=[('topping_category', '=', 1)], ondelete='cascade')
-    topping_ids_2 = fields.One2many('lunch.topping', 'category_id', domain=[('topping_category', '=', 2)], ondelete='cascade')
-    topping_ids_3 = fields.One2many('lunch.topping', 'category_id', domain=[('topping_category', '=', 3)], ondelete='cascade')
+    topping_ids_1 = fields.One2many('lunch.topping', 'category_id', domain=[('topping_category', '=', 1)])
+    topping_ids_2 = fields.One2many('lunch.topping', 'category_id', domain=[('topping_category', '=', 2)])
+    topping_ids_3 = fields.One2many('lunch.topping', 'category_id', domain=[('topping_category', '=', 3)])
     topping_quantity_1 = fields.Selection([
         ('0_more', 'None or More'),
         ('1_more', 'One or More'),
@@ -70,7 +70,7 @@ class LunchTopping(models.Model):
     company_id = fields.Many2one('res.company', default=lambda self: self.env.company)
     currency_id = fields.Many2one('res.currency', related='company_id.currency_id')
     price = fields.Float('Price', digits='Account', required=True)
-    category_id = fields.Many2one('lunch.product.category')
+    category_id = fields.Many2one('lunch.product.category', ondelete='cascade')
     topping_category = fields.Integer('Topping Category', help="This field is a technical field", required=True, default=1)
 
     def name_get(self):

addons/purchase_stock/models/purchase.py

@@ -257,7 +257,7 @@ class PurchaseOrderLine(models.Model):
 
     qty_received_method = fields.Selection(selection_add=[('stock_moves', 'Stock Moves')])
 
-    move_ids = fields.One2many('stock.move', 'purchase_line_id', string='Reservation', readonly=True, ondelete='set null', copy=False)
+    move_ids = fields.One2many('stock.move', 'purchase_line_id', string='Reservation', readonly=True, copy=False)
     orderpoint_id = fields.Many2one('stock.warehouse.orderpoint', 'Orderpoint')
     move_dest_ids = fields.One2many('stock.move', 'created_purchase_line_id', 'Downstream Moves')
     delay_alert = fields.Boolean(string='Delay alert')