pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[IMP] website_sale: avoid reading attributes when unnecessary

Browse Source 
Do not fetch combination info for products having no accessory products, 
this adds additional SQL queries for nothing.

Part-of: odoo/odoo#82374
This commit is contained in:
Victor Feyens
2022-02-21 08:41:31 +00:00
parent 756c5b4922
commit 667842b790
1 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/website_sale/models/sale_order.py
+12 -9
View File
@@ -272,18 +272,21 @@ class SaleOrder(models.Model):
def _cart_accessories(self):
""" Suggest accessories based on 'Accessory Products' of products in cart """
for order in self:
products = order.website_order_line.mapped('product_id')
accessory_products = self.env['product.product']
for line in order.website_order_line.filtered(lambda l: l.product_id):
products = self.website_order_line.product_id
all_accessory_products = self.env['product.product']
for line in self.website_order_line.filtered('product_id'):
accessory_products = line.product_id.product_tmpl_id._get_website_accessory_product()
if accessory_products:
# Do not read ptavs if there is no accessory products to filter
combination = line.product_id.product_template_attribute_value_ids + line.product_no_variant_attribute_value_ids
accessory_products |= line.product_id.product_tmpl_id._get_website_accessory_product().filtered(lambda product:
product not in products and
product._is_variant_possible(parent_combination=combination) and
(product.company_id == line.company_id or not product.company_id)
all_accessory_products |= accessory_products.filtered(
lambda product:
product not in products and
(not product.company_id or product.company_id == line.company_id) and
product._is_variant_possible(parent_combination=combination)
)
return random.sample(accessory_products, len(accessory_products))
return random.sample(all_accessory_products, len(all_accessory_products))
def action_recovery_email_send(self):
for order in self: