pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] pos_six: use same web socket

Browse Source 
When a user cancels a six payment method, he won't be able to select
another six payment method

To reproduce the issue:
(Use demo data. Install l10n_be so your company is in EUR)
1. Create two Payment Methods PM01, PM02 that use the same payment
terminal (a Six one)
2. Add the methods to the POS
3. Start a POS session
4. Select a product and go to payment page
5. Select PM01, send it then remove the line
6. Select PM02, send

Error: Nothing happens (the terminal doesn't receive the instructions).
After several seconds, an error message is displayed "Transaction was
not processed correctly: apiConnectionLostTerminal"

When starting the POS, because there are two payments methods, both are
instanced, each one with its own instance of `PaymentSix`. However, in
the above case, both payment methods use the same terminal. Therefore,
when sending the transaction with the second method (step 6), the API
creates a second WebSocket (for the second instance of `PaymentSix`)
between the POS and the terminal while such a `WebSocket` already exists
(first instance of `PaymentSix`)

OPW-2679181

closes odoo/odoo#85791

X-original-commit: 2912e0d116ceece51bb1274633cbd22e09735232
Signed-off-by: Masereel Pierre <pim@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>
This commit is contained in:
Adrien Widart
2022-03-04 10:08:42 +00:00
parent ff7dc5ae8a
commit 62f329d72f
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/pos_six/static/src/js/payment_six.js
+13
View File
@@ -29,6 +29,19 @@ var PaymentSix = PaymentInterface.extend({
this._super.apply(this, arguments);
this.enable_reversals();
var terminal_ip = this.payment_method.six_terminal_ip;
var instanced_payment_method = _.find(this.pos.payment_methods, function(payment_method) {
return payment_method.use_payment_terminal === "six"
&& payment_method.six_terminal_ip === terminal_ip
&& payment_method.payment_terminal
})
if (instanced_payment_method !== undefined) {
var payment_terminal = instanced_payment_method.payment_terminal;
this.terminal = payment_terminal.terminal;
this.terminalListener = payment_terminal.terminalListener;
return;
}
var settings = new timapi.TerminalSettings();
settings.connectionMode = timapi.constants.ConnectionMode.onFixIp;
settings.connectionIPString = this.payment_method.six_terminal_ip;