[IMP] hr_*: uniformize group category

*:
approvals
hr_apprasaisal
hr_payroll
hr_referral
fleet
hr
hr_attendance
hr_holidays
hr_recruitment
lunch

Change various access rights names to improve understandability for users.
Addition of an officer role in fleet with intermediate accesses

TaskID 2742855

closes odoo/odoo#87545

Related: odoo/enterprise#25741
Signed-off-by: Kevin Baptiste <kba@odoo.com>

addons/fleet/security/fleet_security.xml

@@ -5,7 +5,7 @@
             <field name="sequence">17</field>
         </record>
         <record id="fleet_group_user" model="res.groups">
-            <field name="name">User</field>
+            <field name="name">Officer : Manage all vehicles</field>
             <field name="category_id" ref="base.module_category_human_resources_fleet"/>
             <field name="implied_ids" eval="[(4, ref('base.group_user'))]"/>
         </record>
@@ -63,22 +63,22 @@
         <record id="fleet_rule_contract_visibility_manager" model="ir.rule">
             <field name="name">Administrator has all rights on vehicle's contracts</field>
             <field name="model_id" ref="model_fleet_vehicle_log_contract"/>
-            <field name="groups" eval="[(4, ref('fleet_group_manager'))]"/>
+            <field name="groups" eval="[Command.link(ref('fleet_group_manager'))]"/>
         </record>
         <record id="fleet_rule_service_visibility_manager" model="ir.rule">
             <field name="name">Administrator has all rights on vehicle's services</field>
             <field name="model_id" ref="model_fleet_vehicle_log_services"/>
-            <field name="groups" eval="[(4, ref('fleet_group_manager'))]"/>
+            <field name="groups" eval="[Command.link(ref('fleet_group_manager'))]"/>
         </record>
         <record id="fleet_rule_odometer_visibility_manager" model="ir.rule">
             <field name="name">Administrator has all rights on vehicle's vehicle's odometer</field>
             <field name="model_id" ref="model_fleet_vehicle_odometer"/>
-            <field name="groups" eval="[(4, ref('fleet_group_manager'))]"/>
+            <field name="groups" eval="[Command.link(ref('fleet_group_manager'))]"/>
         </record>
         <record id="fleet_rule_vehicle_visibility_manager" model="ir.rule">
             <field name="name">Administrator has all rights on vehicle</field>
             <field name="model_id" ref="model_fleet_vehicle"/>
-            <field name="groups" eval="[(4, ref('fleet_group_manager'))]"/>
+            <field name="groups" eval="[Command.link(ref('fleet_group_manager'))]"/>
         </record>
         <record id="ir_rule_fleet_vehicle" model="ir.rule">
             <field name="name">Fleet vehicle: Multi Company</field>

addons/fleet/views/fleet_board_view.xml

@@ -65,7 +65,7 @@
       <field name="name">Costs Analysis</field>
       <field name="res_model">fleet.vehicle.cost.report</field>
       <field name="view_mode">graph,pivot</field>
-      <field name="view_id"></field>  
+      <field name="view_id"></field>
       <field name="context" eval="{'search_default_filter_date_start': 1}"/>
       <field name="search_view_id" ref="fleet.fleet_costs_report_view_search"/>
       <field name="help" type="html">

addons/hr/security/hr_security.xml

@@ -2,12 +2,11 @@
 <odoo>
 
     <record id="base.module_category_human_resources_employees" model="ir.module.category">
-        <field name="description">Helps you manage your employees.</field>
         <field name="sequence">9</field>
     </record>
 
     <record id="group_hr_user" model="res.groups">
-        <field name="name">Officer</field>
+        <field name="name">Officer : Manage all employees</field>
         <field name="category_id" ref="base.module_category_human_resources_employees"/>
         <field name="implied_ids" eval="[(6, 0, [ref('base.group_private_addresses'), ref('base.group_user')])]"/>
         <field name="comment">The user will be able to approve document created by employees.</field>

addons/hr_attendance/security/hr_attendance_security.xml

@@ -1,12 +1,11 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
     <record model="ir.module.category" id="base.module_category_human_resources_attendances">
-        <field name="description">Helps you manage the attendances.</field>
         <field name="sequence">14</field>
     </record>
 
     <record id="group_hr_attendance_kiosk" model="res.groups">
-        <field name="name">Kiosk Attendance</field>
+        <field name="name">User : Only kiosk mode</field>
         <field name="category_id" ref="base.module_category_human_resources_employees"/>
         <field name="comment">The user will be able to open the kiosk mode and validate the employee PIN.</field>
         <field name="implied_ids" eval="[(6, 0, [ref('base.group_user')])]"/>
@@ -17,13 +16,13 @@
     </record>
 
     <record id="group_hr_attendance" model="res.groups">
-        <field name="name">Manual Attendance</field>
+        <field name="name">User</field>
         <field name="category_id" ref="base.module_category_human_resources_attendances"/>
         <field name="comment">The user will gain access to the human resources attendance menu, enabling him to manage his own attendance.</field>
     </record>
 
     <record id="group_hr_attendance_user" model="res.groups">
-        <field name="name">Officer</field>
+        <field name="name">Officer : Manage all attendances</field>
         <field name="category_id" ref="base.module_category_human_resources_attendances"/>
         <field name="implied_ids" eval="[(4, ref('hr.group_hr_user')), (4, ref('hr_attendance.group_hr_attendance'))]"/>
     </record>

addons/hr_contract/security/security.xml

@@ -2,7 +2,7 @@
 <odoo>
     <data noupdate="1">
         <record model="ir.module.category" id="base.module_category_human_resources_contracts">
-            <field name="description">Helps you manage your contracts.</field>
+            <field name="description">Enable the user to see and manage the contracts from Employee application.</field>
             <field name="sequence">10</field>
         </record>
 

addons/hr_holidays/security/hr_holidays_security.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
     <record model="ir.module.category" id="base.module_category_human_resources_time_off">
-        <field name="description">Helps you manage your time off.</field>
+        <field name="description">A user without any rights on Time Off will be able to see the application, create his own holidays and manage the requests of the users he's manager of.</field>
         <field name="sequence">10</field>
     </record>
 
@@ -12,7 +12,7 @@
     </record>
 
     <record id="group_hr_holidays_user" model="res.groups">
-        <field name="name">Time Off Officer</field>
+        <field name="name">Officer : Manage all requests</field>
         <field name="category_id" ref="base.module_category_human_resources_time_off"/>
         <field name="implied_ids" eval="[(4, ref('hr_holidays.group_hr_holidays_responsible'))]"/>
     </record>

addons/hr_recruitment/security/hr_recruitment_security.xml

@@ -2,7 +2,7 @@
 <odoo noupdate="1">
 
     <record model="ir.module.category" id="base.module_category_human_resources_recruitment">
-        <field name="description">Helps you manage your recruitments.</field>
+        <field name="description">The user interacting with the application as interviewer don't need any specific access. They'll have access thanks to their interviewer assignation.</field>
         <field name="sequence">11</field>
     </record>
 
@@ -20,7 +20,7 @@
     </record>
 
     <record id="group_hr_recruitment_user" model="res.groups">
-        <field name="name">Officer</field>
+        <field name="name">Officer : Manage all applicants</field>
         <field name="category_id" ref="base.module_category_human_resources_recruitment"/>
         <field name="implied_ids" eval="[(4, ref('hr.group_hr_user'))]"/>
     </record>

addons/lunch/security/lunch_security.xml

@@ -6,7 +6,7 @@
             <field name="sequence">16</field>
         </record>
         <record id="group_lunch_user" model="res.groups">
-            <field name="name">User</field>
+            <field name="name">User : Order your meal</field>
             <field name="category_id" ref="base.module_category_human_resources_lunch"/>
         </record>
         <record id="group_lunch_manager" model="res.groups">

odoo/addons/base/data/ir_module_category_data.xml

@@ -80,7 +80,7 @@
 
         <record model="ir.module.category" id="module_category_human_resources_appraisals">
             <field name="name">Appraisals</field>
-            <field name="description">Helps you manage your appraisals.</field>
+            <field name="description">A user without any rights on Appraisals will be able to see the application, create and manage appraisals for himself and the people he's manager of.</field>
             <field name="sequence">15</field>
         </record>
 

odoo/addons/base/models/res_users.py

@@ -1556,7 +1556,10 @@ class UsersView(models.Model):
                 if allfields and field_name not in allfields:
                     continue
                 # selection group field
-                tips = ['%s: %s' % (g.name, g.comment) for g in gs if g.comment]
+                tips = []
+                if app.description:
+                    tips.append(app.description + '\n')
+                tips.extend('%s: %s' % (g.name, g.comment) for g in gs if g.comment)
                 res[field_name] = {
                     'type': 'selection',
                     'string': app.name or _('Other'),