pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] barcodes: BarcodeEvents handler binding and unbinding

Browse Source 
In order to remove an eventhandler, removeEventListener must receive
the same function reference that was passed to addEventListener. So
the handlers references are kept as attributes of the class.
This commit is contained in:
Arthur Maniet
2015-07-30 07:55:52 +02:00
parent f45904f581
commit 5b01eca5e4
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/barcodes/static/src/js/barcode_events.js
+10 -6
View File
@@ -14,6 +14,10 @@ var BarcodeEvents = core.Class.extend(mixins.PropertiesMixin, {
init: function(parent) {
mixins.PropertiesMixin.init.call(this);
this.setParent(parent);
// Keep a reference of the handler functions to use when adding and removing event listeners
this.__keydown_handler = _.bind(this.keydown_handler, this);
this.__keyup_handler = _.bind(this.keyup_handler, this);
this.__handler = _.bind(this.handler, this);
// Bind event handler once the DOM is loaded
// TODO: find a way to be active only when there are listeners on the bus
$(this.start.bind(this));
@@ -127,15 +131,15 @@ var BarcodeEvents = core.Class.extend(mixins.PropertiesMixin, {
},
start: function(){
document.body.addEventListener('keydown', this.keydown_handler.bind(this), true);
document.body.addEventListener('keyup', this.keyup_handler.bind(this), true);
document.body.addEventListener('keypress', this.handler.bind(this), true);
document.body.addEventListener('keypress', this.__handler, true);
document.body.addEventListener('keydown', this.__keydown_handler, true);
document.body.addEventListener('keyup', this.__keyup_handler, true);
},
stop: function(){
document.body.removeEventListener('keydown', this.keydown_handler.bind(this), true);
document.body.removeEventListener('keyup', this.keyup_handler.bind(this), true);
document.body.removeEventListener('keypress', this.handler.bind(this), true);
document.body.removeEventListener('keypress', this.__handler, true);
document.body.removeEventListener('keydown', this.__keydown_handler, true);
document.body.removeEventListener('keyup', this.__keyup_handler, true);
},
});