[IMP] mail: turn 'ComposerView/hasThreadTyping' into field

Task-2793280

closes odoo/odoo#86457

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

addons/mail/static/src/components/composer/composer.js

@@ -44,7 +44,7 @@ export class Composer extends Component {
             return false;
         }
         return (
-            this.props.hasThreadTyping ||
+            this.composerView.hasThreadTyping ||
             this.composerView.composer.attachments.length > 0 ||
             this.composerView.messageViewInEditing ||
             !this.composerView.isCompact
@@ -196,7 +196,6 @@ Object.assign(Composer, {
         hasDiscardButton: false,
         hasSendButton: true,
         hasThreadName: false,
-        hasThreadTyping: false,
         isExpandable: false,
     },
     props: {
@@ -221,10 +220,6 @@ Object.assign(Composer, {
             type: Boolean,
             optional: true,
         },
-        hasThreadTyping: {
-            type: Boolean,
-            optional: true,
-        },
         showAttachmentsExtensions: {
             type: Boolean,
             optional: true,

addons/mail/static/src/components/composer/composer.xml

@@ -118,7 +118,7 @@
                 </div>
                 <t t-if="hasFooter">
                     <div class="o_Composer_coreFooter" t-att-class="{ 'o-composer-is-compact': composerView.isCompact }">
-                        <t t-if="props.hasThreadTyping">
+                        <t t-if="composerView.hasThreadTyping">
                             <ThreadTextualTypingStatus className="'o_Composer_threadTextualTypingStatus'" threadLocalId="composerView.composer.activeThread.localId"/>
                         </t>
                         <AttachmentList

addons/mail/static/src/components/thread_view/thread_view.xml

@@ -46,7 +46,6 @@
                                 hasDiscardButton="props.hasComposerDiscardButton"
                                 hasSendButton="props.hasComposerSendButton"
                                 hasThreadName="props.hasComposerThreadName"
-                                hasThreadTyping="threadView.hasComposerThreadTyping"
                                 showAttachmentsExtensions="props.showComposerAttachmentsExtensions"
                                 showAttachmentsFilenames="props.showComposerAttachmentsFilenames"
                             />

addons/mail/static/src/models/composer_view.js

@@ -584,6 +584,16 @@ registerModel({
         _computeHasSuggestions() {
             return this.mainSuggestedRecords.length > 0 || this.extraSuggestedRecords.length > 0;
         },
+        /**
+         * @private
+         * @returns {boolean|FieldCommand}
+         */
+        _computeHasThreadTyping() {
+            if (this.threadView && this.threadView.hasComposerThreadTyping !== undefined) {
+                return this.threadView.hasComposerThreadTyping;
+            }
+            return clear();
+        },
         /**
          * @private
          * @returns {boolean|FieldCommand}
@@ -1033,6 +1043,10 @@ registerModel({
             compute: '_computeHasSuggestions',
             default: false,
         }),
+        hasThreadTyping: attr({
+            compute: '_computeHasThreadTyping',
+            default: false,
+        }),
         /**
          * Determines whether the currently active suggestion should be scrolled
          * into view.

addons/mail/static/tests/qunit_suite_tests/components/composer_tests.js

@@ -742,8 +742,15 @@ QUnit.test('do not send typing notification on typing "/" command', async functi
     assert.expect(1);
 
     this.data['mail.channel'].records.push({ id: 20 });
-    const { createComposerComponent, messaging } = await start({
+    await start({
+        autoOpenDiscuss: true,
         data: this.data,
+        discuss: {
+            params: {
+                default_active_id: 20,
+            },
+        },
+        hasDiscuss: true,
         async mockRPC(route, args) {
             if (args.method === 'notify_typing') {
                 assert.step(`notify_typing:${args.kwargs.is_typing}`);
@@ -751,11 +758,6 @@ QUnit.test('do not send typing notification on typing "/" command', async functi
             return this._super(...arguments);
         },
     });
-    const thread = messaging.models['Thread'].findFromIdentifyingData({
-        id: 20,
-        model: 'mail.channel',
-    });
-    await createComposerComponent(thread.composer, { hasThreadTyping: true });
 
     await afterNextRender(() => {
         document.querySelector(`.o_ComposerTextInput_textarea`).focus();
@@ -772,8 +774,15 @@ QUnit.test('do not send typing notification on typing after selecting suggestion
     assert.expect(1);
 
     this.data['mail.channel'].records.push({ id: 20 });
-    const { createComposerComponent, messaging } = await start({
+    await start({
+        autoOpenDiscuss: true,
         data: this.data,
+        discuss: {
+            params: {
+                default_active_id: 20,
+            },
+        },
+        hasDiscuss: true,
         async mockRPC(route, args) {
             if (args.method === 'notify_typing') {
                 assert.step(`notify_typing:${args.kwargs.is_typing}`);
@@ -781,11 +790,6 @@ QUnit.test('do not send typing notification on typing after selecting suggestion
             return this._super(...arguments);
         },
     });
-    const thread = messaging.models['Thread'].findFromIdentifyingData({
-        id: 20,
-        model: 'mail.channel',
-    });
-    await createComposerComponent(thread.composer, { hasThreadTyping: true });
 
     await afterNextRender(() => {
         document.querySelector(`.o_ComposerTextInput_textarea`).focus();
@@ -1382,12 +1386,16 @@ QUnit.test('composer with thread typing notification status', async function (as
     // channel that is expected to be rendered
     // with a random unique id that will be referenced in the test
     this.data['mail.channel'].records.push({ id: 20 });
-    const { createComposerComponent, messaging } = await start({ data: this.data });
-    const thread = messaging.models['Thread'].findFromIdentifyingData({
-        id: 20,
-        model: 'mail.channel',
+    await start({
+        autoOpenDiscuss: true,
+        data: this.data,
+        discuss: {
+            params: {
+                default_active_id: 20,
+            },
+        },
+        hasDiscuss: true,
     });
-    await createComposerComponent(thread.composer, { hasThreadTyping: true });
 
     assert.containsOnce(
         document.body,
@@ -1407,8 +1415,15 @@ QUnit.test('current partner notify is typing to other thread members', async fun
     // channel that is expected to be rendered
     // with a random unique id that will be referenced in the test
     this.data['mail.channel'].records.push({ id: 20 });
-    const { createComposerComponent, messaging } = await start({
+    await start({
+        autoOpenDiscuss: true,
         data: this.data,
+        discuss: {
+            params: {
+                default_active_id: 20,
+            },
+        },
+        hasDiscuss: true,
         async mockRPC(route, args) {
             if (args.method === 'notify_typing') {
                 assert.step(`notify_typing:${args.kwargs.is_typing}`);
@@ -1416,11 +1431,6 @@ QUnit.test('current partner notify is typing to other thread members', async fun
             return this._super(...arguments);
         },
     });
-    const thread = messaging.models['Thread'].findFromIdentifyingData({
-        id: 20,
-        model: 'mail.channel',
-    });
-    await createComposerComponent(thread.composer, { hasThreadTyping: true });
 
     document.querySelector(`.o_ComposerTextInput_textarea`).focus();
     document.execCommand('insertText', false, "a");
@@ -1439,8 +1449,15 @@ QUnit.test('current partner is typing should not translate on textual typing sta
     // channel that is expected to be rendered
     // with a random unique id that will be referenced in the test
     this.data['mail.channel'].records.push({ id: 20 });
-    const { createComposerComponent, messaging } = await start({
+    await start({
+        autoOpenDiscuss: true,
         data: this.data,
+        discuss: {
+            params: {
+                default_active_id: 20,
+            },
+        },
+        hasDiscuss: true,
         hasTimeControl: true,
         async mockRPC(route, args) {
             if (args.method === 'notify_typing') {
@@ -1449,11 +1466,6 @@ QUnit.test('current partner is typing should not translate on textual typing sta
             return this._super(...arguments);
         },
     });
-    const thread = messaging.models['Thread'].findFromIdentifyingData({
-        id: 20,
-        model: 'mail.channel',
-    });
-    await createComposerComponent(thread.composer, { hasThreadTyping: true });
 
     document.querySelector(`.o_ComposerTextInput_textarea`).focus();
     document.execCommand('insertText', false, "a");
@@ -1479,8 +1491,15 @@ QUnit.test('current partner notify no longer is typing to thread members after 5
     // channel that is expected to be rendered
     // with a random unique id that will be referenced in the test
     this.data['mail.channel'].records.push({ id: 20 });
-    const { createComposerComponent, env, messaging } = await start({
+    const { env } = await start({
+        autoOpenDiscuss: true,
         data: this.data,
+        discuss: {
+            params: {
+                default_active_id: 20,
+            },
+        },
+        hasDiscuss: true,
         hasTimeControl: true,
         async mockRPC(route, args) {
             if (args.method === 'notify_typing') {
@@ -1489,11 +1508,6 @@ QUnit.test('current partner notify no longer is typing to thread members after 5
             return this._super(...arguments);
         },
     });
-    const thread = messaging.models['Thread'].findFromIdentifyingData({
-        id: 20,
-        model: 'mail.channel',
-    });
-    await createComposerComponent(thread.composer, { hasThreadTyping: true });
 
     document.querySelector(`.o_ComposerTextInput_textarea`).focus();
     document.execCommand('insertText', false, "a");
@@ -1518,8 +1532,15 @@ QUnit.test('current partner notify is typing again to other members every 50s of
     // channel that is expected to be rendered
     // with a random unique id that will be referenced in the test
     this.data['mail.channel'].records.push({ id: 20 });
-    const { createComposerComponent, env, messaging } = await start({
+    const { env } = await start({
+        autoOpenDiscuss: true,
         data: this.data,
+        discuss: {
+            params: {
+                default_active_id: 20,
+            },
+        },
+        hasDiscuss: true,
         hasTimeControl: true,
         async mockRPC(route, args) {
             if (args.method === 'notify_typing') {
@@ -1528,11 +1549,6 @@ QUnit.test('current partner notify is typing again to other members every 50s of
             return this._super(...arguments);
         },
     });
-    const thread = messaging.models['Thread'].findFromIdentifyingData({
-        id: 20,
-        model: 'mail.channel',
-    });
-    await createComposerComponent(thread.composer, { hasThreadTyping: true });
 
     document.querySelector(`.o_ComposerTextInput_textarea`).focus();
     document.execCommand('insertText', false, "a");