[FIX] stock: avoid unnecessary seq renaming

Previous fix odoo/odoo#139277 was added to avoid the python constraints that didn't allow for duplicate sequence names for picking types. This constraint is now reverted, but it doesn't hurt to keep the renaming for debugging purposes (i.e. in case a seq name is unexpectedly duplicated). The code order of the original fix needs to be updated though since the seq is created before the search so one is always found and renamed in many cases. closes odoo/odoo#143848 closes odoo/odoo#145325 closes odoo/odoo#146050 closes odoo/odoo#146277 closes odoo/odoo#146362 Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com> Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
2023-12-18 23:31:58 +00:00
parent 2363b63dce
commit 59564a4f4a
1 changed files with 1 additions and 1 deletions
@@ -353,8 +353,8 @@ class Warehouse(models.Model):
                self[picking_type].write(values)
            else:
                data[picking_type].update(create_data[picking_type])
+                existing_sequence = IrSequenceSudo.search_count([('company_id', '=', sequence_data[picking_type]['company_id']), ('name', '=', sequence_data[picking_type]['name'])], limit=1)
                sequence = IrSequenceSudo.create(sequence_data[picking_type])
-                existing_sequence = IrSequenceSudo.search_count([('company_id', '=', sequence.company_id.id), ('name', '=', sequence.name)], limit=1)
                if existing_sequence:
                    sequence.name = _("%(name)s (copy)(%(id)s)", name=sequence.name, id=str(sequence.id))
                values.update(warehouse_id=self.id, color=color, sequence_id=sequence.id)