[IMP] mail: make some tools methods private

PURPOSE

Reorganize and lint mail.channel code. Purpose is to ease future modifications
linked to groups and channels in mail / Discuss.

SPECIFICATIONS

Some tools methods do not necessarily require to be public.

LINKS

Prepares Task ID-2070632 (Discuss channel task)
Prepares Task ID-2419762 (SM channel task)
COM PR odoo/odoo#64862

addons/hr_holidays/models/mail_channel.py

@@ -7,8 +7,8 @@ from odoo import fields, models
 class Channel(models.Model):
     _inherit = 'mail.channel'
 
-    def partner_info(self, all_partners, direct_partners):
-        partner_infos = super(Channel, self).partner_info(all_partners, direct_partners)
+    def _get_channel_partner_info(self, all_partners, direct_partners):
+        partner_infos = super(Channel, self)._get_channel_partner_info(all_partners, direct_partners)
         # only search for leave out_of_office_date_end if im_status is on leave
         partners_on_leave = [partner_id for partner_id in direct_partners.ids if 'leave' in partner_infos[partner_id]['im_status']]
         if partners_on_leave:

addons/mail/models/mail_channel.py

@@ -621,7 +621,7 @@ class Channel(models.Model):
     # ------------------------------------------------------------
 
     @api.model
-    def partner_info(self, all_partners, direct_partners):
+    def _get_channel_partner_info(self, all_partners, direct_partners):
         """
         Return the information needed by channel to display channel members
             :param all_partners: list of res.parner():
@@ -654,7 +654,7 @@ class Channel(models.Model):
         all_partners = all_partner_channel.mapped('partner_id')
         direct_channel_partners = all_partner_channel.filtered(lambda pc: channel_dict[pc.channel_id.id].channel_type == 'chat')
         direct_partners = direct_channel_partners.mapped('partner_id')
-        partner_infos = self.partner_info(all_partners, direct_partners)
+        partner_infos = self._get_channel_partner_info(all_partners, direct_partners)
 
         # add last message preview (only used in mobile)
         addPreview = self._context.get('isMobile', False)

addons/mail/static/tests/helpers/mock_server.js

@@ -1028,7 +1028,7 @@ MockServer.include({
         this._widget.call('bus_service', 'trigger', 'notification', notifications);
     },
     /**
-     * Simulates `partner_info` on `mail.channel`.
+     * Simulates `_get_channel_partner_info` on `mail.channel`.
      *
      * @private
      * @param {integer[]} all_partners