pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] web: load_state_tests: avoid undeterministic asserts

Browse Source 
Before this commit, two tests had undeterministic outcomes:
they wanted to assert something in DOM was present at the same tiome as an owl rendering

After this commit, the problematic asserts are removed and the tests behave deterministically.

closes odoo/odoo#73379

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
This commit is contained in:
Lucas Perais (lpe)
2021-07-07 14:31:04 +00:00
parent 14cc991487
commit 4fa4ff685a
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/web/static/tests/webclient/actions/load_state_tests.js
+4 -5
View File
@@ -972,6 +972,7 @@ QUnit.module("ActionManager", (hooks) => {
class MyAction extends Component {
mounted() {
assert.step("myAction mounted");
browser.location.hash = "#action=__test__client__action__&menu_id=1";
}
}
@@ -981,8 +982,7 @@ QUnit.module("ActionManager", (hooks) => {
browser.location.hash = "#action=myAction";
const webClient = await createWebClient({ serverData });
assert.containsOnce(webClient, ".not-here");
assert.containsNone(webClient, ".test_client_action");
assert.verifySteps(["myAction mounted"]);
await nextTick();
assert.containsNone(webClient, ".not-here");
@@ -1001,6 +1001,7 @@ QUnit.module("ActionManager", (hooks) => {
class MyAction extends Component {
mounted() {
assert.step("myAction mounted");
const newURL = baseURL + "#action=__test__client__action__&menu_id=1";
// immediate triggering
window.dispatchEvent(new HashChangeEvent("hashchange", { newURL }));
@@ -1011,9 +1012,7 @@ QUnit.module("ActionManager", (hooks) => {
browser.location.hash = "#action=myAction";
const webClient = await createWebClient({ serverData });
assert.containsOnce(webClient, ".not-here");
assert.containsNone(webClient, ".test_client_action");
assert.verifySteps(["myAction mounted"]);
await nextTick();
assert.containsNone(webClient, ".not-here");