pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] sale_payment: effectively pay and reconcile invoices when journal is configured

Browse Source 
Indentation issue leads to pay and reconcile mechanism being called
only when no journal was set, which is not the real use case.
This commit is contained in:
Thibault Delavallée
2017-11-14 17:00:42 +01:00
parent b34ce85228
commit 4d5d228b15
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/sale_payment/models/payment.py
+4 -4
View File
@@ -88,10 +88,10 @@ class PaymentTransaction(models.Model):
self.acquirer_id.provider, self.sale_order_id.name, self.sale_order_id.id)
return False
self.acquirer_id.journal_id = default_journal
# TDE Note: in post-v11 we could probably add an explicit parameter + update account.payment tx directly at creation, not afterwards
created_invoice.with_context(default_currency_id=self.currency_id.id).pay_and_reconcile(self.acquirer_id.journal_id, pay_amount=created_invoice.amount_total)
if created_invoice.payment_ids:
created_invoice.payment_ids[0].payment_transaction_id = self
# TDE Note: in post-v11 we could probably add an explicit parameter + update account.payment tx directly at creation, not afterwards
created_invoice.with_context(default_currency_id=self.currency_id.id).pay_and_reconcile(self.acquirer_id.journal_id, pay_amount=created_invoice.amount_total)
if created_invoice.payment_ids:
created_invoice.payment_ids[0].payment_transaction_id = self
else:
_logger.warning('<%s> transaction completed, could not auto-generate invoice for %s (ID %s)',
self.acquirer_id.provider, self.sale_order_id.name, self.sale_order_id.id)